Repository navigation
fix(ocsf): report https scheme for TLS-terminated requests - #4684
TaylorMutch merged 2 commits into
Conversation
Closes NVIDIA#4562 Signed-off-by: Eric Curtin <eric.curtin@docker.com>
|
@krishicks @matthewgrossman could you please accept #4562 so the issue check can pass? @pimlock PTAL, and |
EmilienM
left a comment
There was a problem hiding this comment.
Another iteration needed. The ocsf_url helper is a nice way to fix the inspected paths, but the passthrough relay still passes "http" to middleware and to the response-middleware OCSF event on TLS traffic (see inline on relay.rs). So #4562's "all L7 relay emission paths" isn't fully covered yet. Two small nits on the test and docs as well.
Signed-off-by: Eric Curtin <eric.curtin@docker.com>
|
/ok to test 749337f |
Compatibility review (advisory)New or updated breaking changes; see the full report for all findings. 1. api-behavior — No explicit risk acceptance foundTLS-terminated L7 OCSF events change
Review details
Advisory review; publication gates are unchanged. |
TaylorMutch
left a comment
There was a problem hiding this comment.
Reviewed the transport-aware OCSF URL changes and passthrough middleware fixes. Branch Checks passed for this commit, including Rust tests on x86_64 Linux, ARM64 Linux, and macOS.
Summary
L7 OCSF HTTP events recorded
httpfor TLS-terminated requests. Use the transport scheme.Related Issue
Closes #4562
Changes
L7EvalContext::ocsf_url, built fromrequest_scheme."http"URL sites with it.Testing
cargo test,cargo clippy -D warningsandcargo fmtpass foropenshell-supervisor-network.Checklist