Skip to content

fix(ocsf): report https scheme for TLS-terminated requests - #4684

Merged
TaylorMutch merged 2 commits into
NVIDIA:mainfrom
ericcurtin:fix/4562-https-ocsf-url-scheme/ericcurtin
Oct 19, 2026
Merged

TaylorMutch merged 2 commits into
NVIDIA:mainfrom
ericcurtin:fix/4562-https-ocsf-url-scheme/ericcurtin

Conversation

@ericcurtin

Copy link
Copy Markdown
Contributor

Summary

L7 OCSF HTTP events recorded http for TLS-terminated requests. Use the transport scheme.

Related Issue

Closes #4562

Changes

  • Add L7EvalContext::ocsf_url, built from request_scheme.
  • Replace the eight hardcoded "http" URL sites with it.
  • Update sample log lines in docs.

Testing

  • Checks appropriate to the affected code and behavior pass
  • Unit tests added/updated (if applicable)
  • E2E tests added/updated (if applicable)

cargo test, cargo clippy -D warnings and cargo fmt pass for openshell-supervisor-network.

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)
  • Architecture docs updated (if applicable)

Closes NVIDIA#4562

Signed-off-by: Eric Curtin <eric.curtin@docker.com>
@copy-pr-bot

copy-pr-bot Bot commented Oct 18, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@ericcurtin

Copy link
Copy Markdown
Contributor Author

@krishicks @matthewgrossman could you please accept #4562 so the issue check can pass? @pimlock PTAL, and /ok to test aff878e3be761e8e5a8f113dabba2412ae251881 if it looks good. Thank you!

@EmilienM EmilienM left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another iteration needed. The ocsf_url helper is a nice way to fix the inspected paths, but the passthrough relay still passes "http" to middleware and to the response-middleware OCSF event on TLS traffic (see inline on relay.rs). So #4562's "all L7 relay emission paths" isn't fully covered yet. Two small nits on the test and docs as well.

Comment thread crates/openshell-supervisor-network/src/l7/relay.rs
Comment thread crates/openshell-supervisor-network/src/l7/relay.rs Outdated
Comment thread docs/observability/logging.mdx
Signed-off-by: Eric Curtin <eric.curtin@docker.com>
@ericcurtin

Copy link
Copy Markdown
Contributor Author

Addressed review feedback. @EmilienM @pimlock PTAL, and /ok to test 749337f661158ff9240738c2ac45fb189ef5007d if it looks good. Thank you!

@TaylorMutch TaylorMutch self-assigned this Oct 19, 2026
@TaylorMutch

Copy link
Copy Markdown
Collaborator

/ok to test 749337f

@github-actions

Copy link
Copy Markdown

Compatibility review (advisory)

New or updated breaking changes; see the full report for all findings.

1. api-behavior — No explicit risk acceptance found

TLS-terminated L7 OCSF events change http_request.url.scheme from http to https and shorthand URLs from http://host:443/... to https://host/....

  • Impact: SIEM filters, dashboards, and alerts matching scheme == &quot;http&quot; or the documented http://...:443 shorthand stop matching these TLS L7 events.
  • Action: Preserve the baseline telemetry in v0.1.5, or move the semantic change to a minor train with notice and migration guidance for SIEM rules and shorthand parsers.
  • PR: fix(ocsf): report https scheme for TLS-terminated requests #4684
Review details
  • Execution: complete
  • Candidate: PR #4684 (d0cbed1e38577435fcc5e572bd4b00ff3bd0461e)
  • Baseline: 55bf786453395f3fe1858a187152537b457de77d (55bf786453395f3fe1858a187152537b457de77d)
  • Reviewed: rust-sdk, python-sdk, go-sdk, typescript-sdk, api-behavior, cli, configuration, policy, helm, state

Advisory review; publication gates are unchanged.

Branch check run

@TaylorMutch TaylorMutch left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the transport-aware OCSF URL changes and passthrough middleware fixes. Branch Checks passed for this commit, including Rust tests on x86_64 Linux, ARM64 Linux, and macOS.

@TaylorMutch
TaylorMutch enabled auto-merge October 19, 2026 22:53
@TaylorMutch
TaylorMutch added this pull request to the merge queue Oct 19, 2026
Merged via the queue into NVIDIA:main with commit 2798108 Oct 19, 2026
81 of 84 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug(ocsf): HTTPS requests record an HTTP URL scheme

3 participants