Skip to content

(chore): sync bin helper scripts with the bucket template - #612

Merged
niheaven merged 1 commit into
masterfrom
chore/sync-bin-helpers
Oct 18, 2026
Merged

niheaven merged 1 commit into
masterfrom
chore/sync-bin-helpers

Conversation

@niheaven

Copy link
Copy Markdown
Member

Syncs the bin/ helper scripts with the current BucketTemplate versions.

  • Use conventional PR title: <manifest-name[@version]|chore>: <general summary of the pull request>
  • I have read the Contributing Guide

@coderabbitai

coderabbitai Bot commented Oct 18, 2026

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: afc2d992-a9b1-4878-a818-2eac1a220e1e
📥 Commits

Reviewing files that changed from the base of the PR and between a843ae1 and aa483a4.

📒 Files selected for processing: 6
  • bin/auto-pr.ps1
  • bin/checkhashes.ps1
  • bin/checkurls.ps1
  • bin/checkver.ps1
  • bin/formatjson.ps1
  • bin/missing-checkver.ps1

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.

Summary by CodeRabbit

  • Improvements
    • Updated repository maintenance commands to locate the Scoop installation when its path is not already set.
    • Commands now pass directories and supplied options directly to the relevant Scoop tools, improving handling of paths and arguments.
    • The automatic pull request command retains its existing default upstream setting.

Walkthrough

The wrapper scripts now invoke Scoop scripts directly and forward caller arguments. Several scripts use Convert-Path to resolve SCOOP_HOME, and checkhashes.ps1 adds a wrapper for Scoop’s hash checker.

Changes

Scoop wrapper updates

Layer / File(s) Summary
Resolve paths and invoke Scoop scripts
bin/auto-pr.ps1, bin/checkhashes.ps1, bin/checkurls.ps1, bin/checkver.ps1, bin/formatjson.ps1, bin/missing-checkver.ps1
Several wrappers replace Resolve-Path with Convert-Path and replace command strings evaluated with Invoke-Expression with direct script invocation and argument splatting. checkhashes.ps1 adds a wrapper that resolves the Scoop prefix when unset, then invokes Scoop’s hash checker on the repository’s bucket directory. auto-pr.ps1 changes the parameter casing to $Upstream and retains its default.

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to aa483

The wrapper updates preserve the helper paths, bucket-directory arguments, and caller arguments. No actionable merge-blocking risk is evident.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title clearly describes the primary change: syncing the bin helper scripts with the bucket template.
Description check Passed The description provides a relevant summary and confirms the contributing guide checklist item. It omits the required Closes or Relates issue reference, but it is otherwise mostly complete.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (6 skipped: 6 unsupported.)

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@niheaven
niheaven merged commit 528dd58 into master Oct 18, 2026
6 checks passed
@niheaven
niheaven deleted the chore/sync-bin-helpers branch October 18, 2026 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant