Repository navigation
Combine the 0.88 RC sections into v0.88.0 - #59122
Closed
fabriziocucci wants to merge 1 commit into
Closed
fabriziocucci wants to merge 1 commit into
fabriziocucci wants to merge 1 commit into
Conversation
Summary: Replaces the six per-RC headings (rc.0, rc.1, rc.2, rc.3, rc.4, rc.6) with the single `## v0.88.0` section the stable release publishes. 173 entries in, 170 out, deduped by commit sha, sorted alphabetically by scope, empty sections omitted. Four entries removed and one added, each verified against `0.88-stable` by content rather than by sha ancestry: - `11f9a7f4491` RCTArrayBuffer codegen change: reverted by 639cded. `RCTArrayBuffer` appears in 0 files on the branch. - `ab2ea649e65` TurboModule EventEmitter payload alignment: reverted by 070af03, a clean inverse (497 lines each way). - `4043e818f16` automatic `accessible` with `role`: reverted by adde1e5. `View.js` has no `role != null` guard on the branch. This revert is hand-written with no `This reverts commit` line, so it is not auto-detectable and was removed by hand. - `47fad096a4f` `npx react-native spm`: the content shipped in 0.87. The v0.87.1 tag carries 42 spm files and the 0.87 release post announces Swift Package Manager. The main-branch commit landed after the 0.87 cut, so sha ancestry reports it as new; content says otherwise. - `8415753e21c` iOS `fontVariationSettings`: ADDED. It is on `0.88-stable`, absent from v0.87.1 and so new in 0.88, but the generator never emitted it. Without this the changelog implies the feature is Android-only while the release post documents iOS support. Every commit link was checked to resolve and to match its link text. Differential Revision: D125284660
meta-cla
Bot
added
the
CLA Signed
|
@fabriziocucci has exported this pull request. If you are a Meta employee, you can view the originating Diff in D125284660. |
|
This pull request has been merged in 68b7ce2. |
meta-codesync Bot
pushed a commit
that referenced
this pull request
Oct 16, 2026
Summary: Two workflows stopped working after the move to `react/react-native`, because their regexes only allow `github.com/facebook/react-native`: - **Merged pull requests no longer get the release FAQ comment.** Before the move, `react-native-bot` posted "This pull request was successfully merged by author in **sha**" with links to "When will my fix make it into a release?" and "How to file a pick request?". The last one is on #56769 (June 9). Pull requests merged on October 15 (#59122, #59050, #59016) only have the `meta-codesync` comment. - **Issues that link a pull request as the reproducer still get `Needs: Repro`.** Examples: #58970, #58495, #58445, #55708. The bot's message for `Needs: Repro` asks for a pull request that edits `RNTesterPlayground.js`, but the bot does not accept a link to one. ### Why 1. `.github/workflows/close-pr.yml` looks for `Pull Request resolved: https://github.com/facebook/react-native/pull/N` in the commit message. Commits now say `https://github.com/react/react-native/pull/N`, so `getClosedPrIfExists` returns `undefined` and the script stops before `createComment`. #57167 changed the `if:` line in this file to `react/react-native`, but not the regex. The regex is written with escaped slashes (`facebook\/react-native`). 2. `.github/workflow-scripts/checkForReproducer.js` builds the pull request pattern in a template literal with single backslashes. In a template literal, `\d` is just `d`, so the pattern is `https?://github.com/facebook/react-native/pull/d+/?`. It did not match real links even before the move (the line was added in #50848). The other two patterns in the same function use `\\` and work. In the whole repo, `facebook\/react-native` appears only in these two lines. ### Fix Both regexes now accept `facebook` and `react`. People still write links with `facebook`: the four issues above all do. In `checkForReproducer.js`, the pattern now uses `\\` like the other two patterns. `(?:...)` does not capture, so the group numbers in `close-pr.yml` do not change. The new test file is `checkForReproducer-links-test.js`, so it does not conflict with `checkForReproducer-test.js` from #58429. That PR fixes a different problem in the same script: the bot treats its own `Needs: Repro` label as a maintainer change. Because of that, an issue that already has the label keeps it after an edit, also with this PR. New issues with a pull request link do not get the label. ## Changelog: [INTERNAL] [FIXED] - Fix pull request link regexes in the close-pr and check-for-reproducer workflows after the move to react/react-native Pull Request resolved: #59128 Test Plan: Windows 11, Node 22.17.1, Yarn 1.22.22. New Jest test for `checkForReproducer` with 4 cases: a link to a pull request in `react/react-native`, the same link with `facebook/react-native`, a pull request in another repository, and no link. ``` yarn test .github/workflow-scripts ``` | Code | Result | | --- | --- | | `main` (e04aaf6) | 2 of the 4 new tests fail: both pull request links are not accepted | | this PR | 11 suites, 72 tests pass | Each part of the fix is needed: - `facebook|react` with single backslashes: both link tests fail. - Double backslashes with only `facebook`: the `react` link test fails. `close-pr.yml` runs an inline script, so it has no Jest test. I took `prClosingRegex` from the file and ran `getClosedPrIfExists` (copied from the file) on real commit messages from `main`: | Commit message | `main` | this PR | | --- | --- | --- | | #59016: `Pull Request resolved: https://github.com/react/react-native/pull/59016` | `undefined` | `59016` | | #56769: `Pull Request resolved: https://github.com/facebook/react-native/pull/56769` | `56769` | `56769` | | "Update React Native DevTools binaries", no pull request link | `undefined` | `undefined` | `npx prettier --check` passes for the 3 files. Not covered: - I did not run the workflows. They run on push to `main` and on issue events in this repository. - `yarn lint` does not check these files, because ESLint skips the `.github` folder. Reviewed By: cipolleschi Differential Revision: D125650549 Pulled By: cortinico fbshipit-source-id: c1d1b49381730f755d13e3c822ac1df33a4808b8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Replaces the six per-RC headings (rc.0, rc.1, rc.2, rc.3, rc.4, rc.6) with the single
## v0.88.0section the stable release publishes. 173 entries in, 170 out, deduped by commit sha, sorted alphabetically by scope, empty sections omitted.Four entries removed and one added, each verified against
0.88-stableby content rather than by sha ancestry:11f9a7f4491RCTArrayBuffer codegen change: reverted by 639cded.RCTArrayBufferappears in 0 files on the branch.ab2ea649e65TurboModule EventEmitter payload alignment: reverted by 070af03, a clean inverse (497 lines each way).4043e818f16automaticaccessiblewithrole: reverted by adde1e5.View.jshas norole != nullguard on the branch. This revert is hand-written with noThis reverts commitline, so it is not auto-detectable and was removed by hand.47fad096a4fnpx react-native spm: the content shipped in 0.87. The v0.87.1 tag carries 42 spm files and the 0.87 release post announces Swift Package Manager. The main-branch commit landed after the 0.87 cut, so sha ancestry reports it as new; content says otherwise.8415753e21ciOSfontVariationSettings: ADDED. It is on0.88-stable, absent from v0.87.1 and so new in 0.88, but the generator never emitted it. Without this the changelog implies the feature is Android-only while the release post documents iOS support.Every commit link was checked to resolve and to match its link text.
Differential Revision: D125284660