Repository navigation
Feature: Align admin tooltips - #3626
Merged
Merged
Conversation
Contributor
|
This pull request does not currently match the merge queue conditions, so it cannot be queued from here. The box comes back if it matches again. |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused tooltip changes preserve permission enforcement, and no blocking issues were identified.
No open issues 🎉
What changed in this PR
Standardizes permission tooltips across NETworkManager so disabled administrative actions explain why elevation is required.
Changes:
- Adds a reusable permission-tooltip helper and applies it across five views.
- Reuses wrapping styles for permission hints and error tooltips.
- Documents the improvements in the changelog.
| File | Description |
|---|---|
| Website/docs/changelog/next-release.md | Documents permission hints and error-text wrapping. |
| Source/NETworkManager/Views/NetworkInterfaceView.xaml | Adds configuration permission hints. |
| Source/NETworkManager/Views/NeighborTableView.xaml | Adds entry-management permission hints. |
| Source/NETworkManager/Views/HostsFileEditorView.xaml | Adds editing permission hints. |
| Source/NETworkManager/Views/FirewallView.xaml | Adds rule-management permission hints. |
| Source/NETworkManager/Views/DiscoveryProtocolView.xaml | Adds a capture permission hint. |
| Source/NETworkManager/Resources/Styles/ToolTipStyles.xaml | Introduces a reusable wrapping style. |
| Source/NETworkManager/Resources/Styles/RectangleStyles.xaml | Enables wrapping for error-icon tooltips. |
| Source/NETworkManager.Utilities.WPF/PermissionToolTipHelper.cs | Implements permission-dependent tooltips. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
To-Do
Contributing
By submitting this pull request, I confirm the following: