Repository navigation
Feature: Delete / Enable / Disable multiple firewall rules - #3627
Merged
Merged
Conversation
Contributor
|
This pull request does not currently match the merge queue conditions, so it cannot be queued from here. The box comes back if it matches again. |
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Missing-rule validation omits part of the selection, and failed bulk actions skip the documented automatic refresh.
3 open issues
1 file not reviewed
Source/NETworkManager.Localization/Resources/Strings.Designer.cs: Generated file
What changed in this PR
Adds bulk enable, disable, and delete actions to NETworkManager’s firewall interface.
Changes:
- Adds multi-selection commands, confirmation messages, and modification guards.
- Shares PowerShell execution and rule-existence validation.
- Documents bulk actions and expected failure recovery.
| File | Description |
|---|---|
| Website/docs/changelog/next-release.md | Announces bulk firewall actions. |
| Website/docs/application/firewall.md | Documents selection, actions, and recovery. |
| Source/NETworkManager/Views/FirewallView.xaml.cs | Updates selection-dependent menu properties. |
| Source/NETworkManager/Views/FirewallView.xaml | Adds bulk-action menu items. |
| Source/NETworkManager/ViewModels/FirewallViewModel.cs | Handles bulk commands and confirmations. |
| Source/NETworkManager.Models/Firewall/Firewall.cs | Adds shared bulk PowerShell operations. |
| Source/NETworkManager.Localization/Resources/Strings.resx | Adds bulk-delete messages. |
| Source/NETworkManager.Localization/Resources/Strings.Designer.cs | Exposes new localized strings. |
Review effort: Balanced
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Elevated bulk firewall operations and partial-failure behavior need manual validation on Windows.
No open issues 🎉
3 resolved since last review
1 file not reviewed
Source/NETworkManager.Localization/Resources/Strings.Designer.cs: Generated file
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
To-Do
Contributing
By submitting this pull request, I confirm the following: