Repository navigation
Show the GitHub Trending #5 finish at the top of the README - #141
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem
On Sunday, October 11, Open Intelligent UI reached #5 on GitHub Trending's daily list. A day earlier, on October 10, Trendshift ranked it #3 TypeScript Repository Of The Day. The README says neither. People deciding whether a project is alive and worth a clone read the README header first, and right now it shows them nothing about this.
The approach
Two Trendshift badges go on their own line under the CI and license badges, inside the centered header. Both link to the repository's Trendshift page. These are the exact badge endpoints Trendshift uses on that page's achievements section. Each one shows the best rank the repository has reached, not today's rank. So the header won't show a lower number next week, and it updates without anyone editing it if the project ranks higher later.
Only two of the four achievements made it in. Trendshift also lists #24 Repository Of The Day across all languages and #18 TypeScript Repository Of The Week. Both are true, but showing four badges would bury the #5 under weaker numbers.
The cost is a dependency on a third-party image host. If trendshift.io is down, GitHub shows each badge's alt text, which makes the same claim in words.
What is not covered
Verification
curlagainst both badge URLs returns200 image/svg+xmlat 250x55. The SVG text reads "GITHUB TRENDING / perf: MutationObserver on document.body fires on every DOM mutation #5 Repository Of The Day" and "TRENDSHIFT · TypeScript / security: iframe sandbox allows same-origin access to parent page #3 Repository Of The Day".camo.githubusercontent.com) serves both images with a 200. The rendered README on this branch loads both images at their natural 250x55 size. The screenshot above is from that render.