Repository navigation
Fix the Artboard tool resizing and nudging locked or hidden artboards - #4729
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 1 file
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Keavon
enabled auto-merge
October 15, 2026 09:43
Contributor
There was a problem hiding this comment.
1 issue found across 1 file (changes from recent commits).
Confidence score: 4/5
- In
artboard_tool.rs, the test’s preliminary mouse move redraws overlays and clears the stale cage before pointer-down, so it bypasses the resize guard it’s meant to cover. Send pointer-down at the handle without that preliminary move.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="editor/src/messages/tool/tool_messages/artboard_tool.rs">
<violation number="1" location="editor/src/messages/tool/tool_messages/artboard_tool.rs:1185">
P2: This `drag` redraws overlays before pointer-down, clearing the stale cage and bypassing the resize guard this test is meant to cover. Send pointer-down at the handle without the helper’s preliminary mouse move.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
| editor.press(Key::ArrowRight, ModifierKeys::SHIFT).await; | ||
| assert_bounds(&editor, artboard, [DVec2::new(100., 100.), DVec2::new(200., 160.)]); | ||
|
|
||
| drag(&mut editor, DVec2::new(150., 160.), DVec2::new(150., 220.), ModifierKeys::empty()).await; |
Contributor
There was a problem hiding this comment.
P2: This drag redraws overlays before pointer-down, clearing the stale cage and bypassing the resize guard this test is meant to cover. Send pointer-down at the handle without the helper’s preliminary mouse move.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At editor/src/messages/tool/tool_messages/artboard_tool.rs, line 1185:
<comment>This `drag` redraws overlays before pointer-down, clearing the stale cage and bypassing the resize guard this test is meant to cover. Send pointer-down at the handle without the helper’s preliminary mouse move.</comment>
<file context>
@@ -1161,4 +1161,28 @@ mod test_artboard {
+ editor.press(Key::ArrowRight, ModifierKeys::SHIFT).await;
+ assert_bounds(&editor, artboard, [DVec2::new(100., 100.), DVec2::new(200., 160.)]);
+
+ drag(&mut editor, DVec2::new(150., 160.), DVec2::new(150., 220.), ModifierKeys::empty()).await;
+ assert_bounds(&editor, artboard, [DVec2::new(100., 100.), DVec2::new(200., 160.)]);
+ }
</file context>
Suggested change
| drag(&mut editor, DVec2::new(150., 160.), DVec2::new(150., 220.), ModifierKeys::empty()).await; | |
| editor.left_mousedown(150., 160., ModifierKeys::empty()).await; | |
| move_to(&mut editor, DVec2::new(150., 220.), ModifierKeys::empty()).await; | |
| editor.left_mouseup(150., 220., ModifierKeys::empty()).await; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.