Skip to content

Fix the Artboard tool resizing and nudging locked or hidden artboards - #4729

Merged
Keavon merged 2 commits into
masterfrom
bugfix-artboard-tool-locked
Oct 15, 2026
Merged

Keavon merged 2 commits into
masterfrom
bugfix-artboard-tool-locked

Conversation

@Keavon

@Keavon Keavon commented Oct 15, 2026

Copy link
Copy Markdown
Member

No description provided.

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 1 file

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread editor/src/messages/tool/tool_messages/artboard_tool.rs
@Keavon
Keavon enabled auto-merge October 15, 2026 09:43

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 1 file (changes from recent commits).

Confidence score: 4/5

  • In artboard_tool.rs, the test’s preliminary mouse move redraws overlays and clears the stale cage before pointer-down, so it bypasses the resize guard it’s meant to cover. Send pointer-down at the handle without that preliminary move.
Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="editor/src/messages/tool/tool_messages/artboard_tool.rs">

<violation number="1" location="editor/src/messages/tool/tool_messages/artboard_tool.rs:1185">
P2: This `drag` redraws overlays before pointer-down, clearing the stale cage and bypassing the resize guard this test is meant to cover. Send pointer-down at the handle without the helper’s preliminary mouse move.</violation>
</file>

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

editor.press(Key::ArrowRight, ModifierKeys::SHIFT).await;
assert_bounds(&editor, artboard, [DVec2::new(100., 100.), DVec2::new(200., 160.)]);

drag(&mut editor, DVec2::new(150., 160.), DVec2::new(150., 220.), ModifierKeys::empty()).await;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: This drag redraws overlays before pointer-down, clearing the stale cage and bypassing the resize guard this test is meant to cover. Send pointer-down at the handle without the helper’s preliminary mouse move.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At editor/src/messages/tool/tool_messages/artboard_tool.rs, line 1185:

<comment>This `drag` redraws overlays before pointer-down, clearing the stale cage and bypassing the resize guard this test is meant to cover. Send pointer-down at the handle without the helper’s preliminary mouse move.</comment>

<file context>
@@ -1161,4 +1161,28 @@ mod test_artboard {
+		editor.press(Key::ArrowRight, ModifierKeys::SHIFT).await;
+		assert_bounds(&editor, artboard, [DVec2::new(100., 100.), DVec2::new(200., 160.)]);
+
+		drag(&mut editor, DVec2::new(150., 160.), DVec2::new(150., 220.), ModifierKeys::empty()).await;
+		assert_bounds(&editor, artboard, [DVec2::new(100., 100.), DVec2::new(200., 160.)]);
+	}
</file context>
Suggested change
drag(&mut editor, DVec2::new(150., 160.), DVec2::new(150., 220.), ModifierKeys::empty()).await;
editor.left_mousedown(150., 160., ModifierKeys::empty()).await;
move_to(&mut editor, DVec2::new(150., 220.), ModifierKeys::empty()).await;
editor.left_mouseup(150., 220., ModifierKeys::empty()).await;

@Keavon
Keavon added this pull request to the merge queue Oct 15, 2026
Merged via the queue into master with commit a89f1c5 Oct 15, 2026
10 checks passed
@Keavon
Keavon deleted the bugfix-artboard-tool-locked branch October 15, 2026 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant