Skip to content

fix(support): resolve shared links on project pages and previews - #498

Merged
ReenigneArcher merged 2 commits into
masterfrom
fix/includes/support-url
Oct 19, 2026
Merged

ReenigneArcher merged 2 commits into
masterfrom
fix/includes/support-url

Conversation

@ReenigneArcher

@ReenigneArcher ReenigneArcher commented Oct 19, 2026 •

Copy link
Copy Markdown
Member

Description

Theme consumers with a base path currently render the support button as /libvirtualhid/support, which returns 404. Build the shared support link from a separate root_baseurl, empty on published sites, so project paths are omitted without hardcoding a domain.

The Read the Docs build sets root_baseurl from the preview version. Main-site PR previews therefore link to /498/support instead of /support, while published consumers link to /support.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Testing

  • LiquidJS rendered the actual support include for 8 contexts: root, project, nested project, localhost, and main-site previews for PRs 498 and 512 with root and nested pages. All generated support links resolved to the expected path on the same origin.
  • Executed the actual preview-config generation commands with both PR numbers and used their YAML output when rendering the preview cases.
  • Bash syntax validation of the normalized build script and git diff --check passed.
  • No permanent test infrastructure was added for this small template/config change; the rendering and config checks were run with a temporary local harness.
  • Full Jekyll build was not run: Ruby/Bundler are unavailable and Docker is not running. Hosted preview validation remains pending.

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Tests have been added or updated for new or modified functionality, including regression tests for bug fixes

AI Usage

See our AI usage policy.

  • AI tools were used while preparing this PR

@codecov

codecov Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (f802822) to head (42cd77a).
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #498   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines         1000      1000           
  Branches       132       132           
=========================================
  Hits          1000      1000           

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f802822...42cd77a. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ReenigneArcher ReenigneArcher changed the title fix(support): link to domain root from theme consumers fix(support): resolve shared links on project pages and previews Oct 19, 2026
@sonarqubecloud

Copy link
Copy Markdown

@ReenigneArcher
ReenigneArcher merged commit ff68966 into master Oct 19, 2026
18 checks passed
@ReenigneArcher
ReenigneArcher deleted the fix/includes/support-url branch October 19, 2026 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant