Repository navigation
ci(release): tag Go SDK module on stable releases - #4262
Merged
Merged
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
purp
marked this pull request as ready for review
October 6, 2026 22:47
purp
requested review from
a team,
derekwaynecarr,
mrunalp and
sjenning
as code owners
October 6, 2026 22:47
2 tasks
SDAChess
previously approved these changes
Oct 15, 2026
Collaborator
|
@purp can you resolve the conflict? This is a good one to get in for 0.1.6 |
Go resolves the sdk/go submodule version from sdk/go/vX.Y.Z tags, so without one pkg.go.dev only shows v0.0.0 pseudo-versions from main. Add a Release Tag job that creates the prefixed tag at the release commit and asks the Go module proxy to fetch it. Signed-off-by: Jim Meyer <jimeyer@nvidia.com>
purp
force-pushed
the
ci/4261-go-sdk-release-tag/purp
branch
from
October 20, 2026 21:50
2b956d5 to
acca9b3
Compare
TaylorMutch
approved these changes
Oct 20, 2026
TaylorMutch
left a comment
TaylorMutch
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed the Go module tagging and release workflow. The implementation is correct for the current v0/v1 module path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Go resolves the
sdk/gomodule's versions from directory-prefixed tags (sdk/go/vX.Y.Z), and the release process only creates rootvX.Y.Ztags, so pkg.go.dev shows onlyv0.0.0-…pseudo-versions. This adds a Release Tag job that creates the prefixed tag for each stable release.Related Issue
Closes #4261
Changes
tag-sdk-gojob inrelease-tag.yml, afterrelease, skipped for prereleases (same gate as the TypeScript SDK publish).sdk/go/v${semver}tag at the release commit through the GitHub API, with no checkout. If the tag already exists at the same commit (re-run), it does nothing. If it exists at a different commit, the job fails.Testing
actionlint(with shellcheck) passes onrelease-tag.ymlzizmor --offlinereports no new findingsgh api …/git/ref/tags/<missing>exits non-zero, which the job uses to detect a missing tagworkflow_dispatchof an existing tag.Checklist
🤖 Generated with Claude Code