Repository navigation
feat(supervisor): let operators require specific middleware bindings - #4678
Draft
freeqaz-openai wants to merge 1 commit into
Draft
freeqaz-openai wants to merge 1 commit into
freeqaz-openai wants to merge 1 commit into
Conversation
Let operators require and limit the operation and phase pairs that an external middleware may expose. Validate the same binding policy at gateway startup and when a supervisor discovers the service, and keep only authorized bindings in the registry used for dispatch. Preserve dynamic discovery and the existing wire configuration when no binding policy is set. Document that older supervisors must be upgraded before relying on binding restrictions. Signed-off-by: Free Wortley <freeqaz@openai.com>
|
Thank you for your interest in contributing to OpenShell, @freeqaz-openai. This project uses a vouch system for first-time contributors. Before submitting a pull request, you need to be vouched by a maintainer. To get vouched:
See CONTRIBUTING.md for details. |
|
All contributors have signed the DCO ✍️ ✅ |
Author
|
I have read the DCO document and I hereby sign the DCO. |
peppywolfym-lab
approved these changes
Oct 18, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Let an operator require a specific supervisor middleware binding, such as HTTP request inspection before credentials are attached. Today a service can advertise only a response hook, and OpenShell will correctly skip it on requests. That behavior is useful for response middleware, but it cannot express “this service must participate in request inspection.”
This is an opt-in registration contract. The sandbox policy must still attach the middleware and use
on_error: fail_closedwhere a failed call should deny a request. Upgrade supervisors before requiring the policy; older supervisors do not enforce it, and an unsuccessful configuration update does not retroactively replace the last working configuration.Related issue
Closes #2282. Draft for design review; the issue does not currently have
state:accepted. Please leave the normal issue-acceptance and review checks in place.Changes
dynamic(default): preserve existing manifest-driven behavior, including response-only services.allowlist: every configured binding must be advertised; ignore other advertised bindings.exact: the configured and advertised binding sets must match.The gateway checks the manifest, carries the operator's policy in sandbox configuration, and the supervisor checks its own
Describeresponse before installing the registry. No credential, sender, transport, or per-request wire protocol changes.Testing