[compot-dev]

Closes #247.

UdpHeartbeat counts a packet after send() returns, and the test's toy socket can get the datagram before that, so assertTrue(h.sent() >= 4) right after the 4th receive() failed now and then (2 of 4 local runs). The test now waits up to 1 s for the count and prints it on failure.

Test-only: no new version (the version check skips android/app/src/test).

• Docker build as CI: testDebugUnitTest (359 tests), lintDebug, assembleDebug; UdpHeartbeatTest alone 6 runs in a row, all pass

[qodo-free-for-open-source-projects]

PR Summary by Qodo

Prevent a sent-count race in UdpHeartbeatTest

🧪 Tests 🐞 Bug fix 🕐 Less than 5 minutes

AI Description

• Wait up to one second for the heartbeat's sent count after receiving four datagrams.
• Include the observed count in assertion failures to help diagnose future test failures.

Diagram

sequenceDiagram
    participant H as Heartbeat thread
    participant S as UDP socket
    participant T as Test thread
    H->>S: Send heartbeat
    S->>T: Deliver fourth datagram
    H->>H: Increment sent count
    T->>H: Poll sent count
    H-->>T: Count at least four
    T->>T: Assert count

Loading

High-Level Assessment

Keep the bounded wait in the test. It accommodates the existing ordering between datagram delivery and counter increment without changing production behavior; an immediate assertion cannot reliably establish that the count has caught up.

Files changed (1) +4 / -1

Tests (1) +4 / -1

UdpHeartbeatTest.javaWait for the fourth heartbeat to appear in the sent count +4/-1

Wait for the fourth heartbeat to appear in the sent count

• Replaces the immediate sent-count assertion with polling at five-millisecond intervals for up to one second. The assertion reports the observed count if the wait expires.

android/app/src/test/java/com/openipc/decoder/UdpHeartbeatTest.java

[qodo-free-for-open-source-projects]

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Tip of the day

💡 Did you know, you can open the rule or relationship behind a finding in one click

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗