Repository navigation
fix(managed): accept scalar effort in model responses - #17
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Managed Agent and Session responses can contain a string-valued model effort, such as
"effort": "low". The response model previously accepted only an object, causing otherwise successful responses to raiseAPIResponseValidationErrorwhen strict response validation was enabled.Accept string effort values alongside the existing structured form. Add synchronous and asynchronous regression tests for both resources, preserve rejection of invalid numeric/list values, and document the fix in the changelog.
Why
The strict Session-list integration check exposed a mismatch between the SDK response model and the service's canonical string representation. Fixing the model lets the strict check remain enabled.
Verification
uv run make lintuv run make typecheckuv run make testuv run make docs-check--helpsmoke checksCommands and results:
The installed-wheel validation used Pydantic 2.13.5. The full internal acceptance pipeline will be rerun after this PR is merged; the targeted checks above do not substitute for that run.
Impact
CHANGELOG.mdunderUnreleased, or not applicable (explain below).env.live, logs, or generated test output committedAdditional context:
tests/test_response_alignment.py.--helpchecks were not rerun for this fix.