Repository navigation
feat(extensions): engines ranges with several comparators - #1630
Merged
Merged
Conversation
….0.0) The ClickHouse driver declares >=0.4.0 <3.0.0, which engineRangeAllows could not read (only >=x.y.z and ^x.y.z), so the extension showed on every version. Space separated comparators now all have to hold; * means any version; a range that is still not understood stays null (shown with a warning) instead of a guess.
Open
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found with the first real registry record: the ClickHouse driver declares
engines.querya_desktopas>=0.4.0 <3.0.0, andengineRangeAllowscould not read it (only>=x.y.zand^x.y.z), so the extension was visible on every version and the tester warned about an unsupported range.engineRangeAllows: space-separated comparators that must all hold (>=,>,<=,<,=,^), and*alone for any version. Anything it still cannot read (~0.4,||, a bare version,* <3.0.0) isnull: shown with a warning, not guessed.HostVersiongets<=.*, unreadable ranges and the two warnings. Docs (extension-manifest.md) and CHANGELOG.The registry gets a matching check (refuse a range the app cannot read) in its own repository. Not run locally; CI decides.