Repository navigation
feat(ext-tester): --manifest-only - #1631
Merged
Merged
Conversation
Open
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The part of the manifest-versions discussion that #1629 left out: check
manifest.jsonagainst the emulated host without running the extension.querya-ext-tester <dir> --manifest-only --target-version x.y.zruns themanifestcheck (required fields,enginesagainst the host,manifestVersionagainst the host, drivers) and stops: nothing is launched, so no database and no executable are needed. Exit code as usual (1 on an error).QueryaExtensionHarness.run(manifestOnly: true); tests: nothing is started even with no executable, a format the host cannot read fails, a missing manifest fails.What it is for: the registry's CI can check the manifest of every record (themes and drivers without a test database too) against each host in
hosts.jsonthat itsenginesrange includes. That step has to use a released tester, so it follows the release that carries this flag (listed in #1625). Not run locally; CI decides.