Skip to content

use naga-wgsl target for wgpu #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Firestar99 merged 2 commits into from
Oct 14, 2026
Merged

use naga-wgsl target for wgpu #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5d9a7f4
use naga-wgsl target for wgpu
Firestar99 Oct 1, 2026
b49609c
remove shared target dir, breaks `cargo clippy`
Firestar99 Oct 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions .cargo/config.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,2 @@
[build]
target-dir = "target"

[alias]
xtask = "run --package xtask --"
8 changes: 5 additions & 3 deletions generated/graphics/ash/cargo-gpu/mygraphics/build.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,16 +9,18 @@ pub fn main() -> anyhow::Result<()> {
.copied()
.collect::<PathBuf>();

let target = "spirv-unknown-vulkan1.3";
let install = Install::from_shader_crate(crate_path.clone())
.within_build_script()
.run()?;
let mut builder = install.to_spirv_builder(crate_path, "spirv-unknown-vulkan1.3");
let mut builder = install.to_spirv_builder(crate_path, target);
builder.build_script.defaults = true;
builder.shader_panic_strategy = ShaderPanicStrategy::SilentExit;
builder.spirv_metadata = SpirvMetadata::Full;

let compile_result = builder.build()?;
let spv_path = compile_result.module.unwrap_single();
println!("cargo::rustc-env=SHADER_SPV_PATH={}", spv_path.display());
let artifact = compile_result.module.unwrap_single();

println!("cargo::rustc-env=SHADER_SPV_PATH={}", artifact.display());
Ok(())
}
8 changes: 5 additions & 3 deletions generated/graphics/ash/spirv-builder/mygraphics/build.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,15 @@ pub fn main() -> anyhow::Result<()> {
.copied()
.collect::<PathBuf>();

let mut builder = SpirvBuilder::new(crate_path, "spirv-unknown-vulkan1.3");
let target = "spirv-unknown-vulkan1.3";
let mut builder = SpirvBuilder::new(crate_path, target);
builder.build_script.defaults = true;
builder.shader_panic_strategy = ShaderPanicStrategy::SilentExit;
builder.spirv_metadata = SpirvMetadata::Full;

let compile_result = builder.build()?;
let spv_path = compile_result.module.unwrap_single();
println!("cargo::rustc-env=SHADER_SPV_PATH={}", spv_path.display());
let artifact = compile_result.module.unwrap_single();

println!("cargo::rustc-env=SHADER_SPV_PATH={}", artifact.display());
Ok(())
}
8 changes: 5 additions & 3 deletions generated/graphics/wgpu/cargo-gpu/mygraphics/build.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,16 +9,18 @@ pub fn main() -> anyhow::Result<()> {
.copied()
.collect::<PathBuf>();

let target = "spirv-unknown-naga-wgsl";
let install = Install::from_shader_crate(crate_path.clone())
.within_build_script()
.run()?;
let mut builder = install.to_spirv_builder(crate_path, "spirv-unknown-vulkan1.3");
let mut builder = install.to_spirv_builder(crate_path, target);
builder.build_script.defaults = true;
builder.shader_panic_strategy = ShaderPanicStrategy::SilentExit;
builder.spirv_metadata = SpirvMetadata::Full;

let compile_result = builder.build()?;
let spv_path = compile_result.module.unwrap_single();
println!("cargo::rustc-env=SHADER_SPV_PATH={}", spv_path.display());
let artifact = compile_result.module.unwrap_single();

println!("cargo::rustc-env=SHADER_WGSL_PATH={}", artifact.display());
Ok(())
}
4 changes: 2 additions & 2 deletions generated/graphics/wgpu/cargo-gpu/mygraphics/src/wgpu_renderer/render_pipeline.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ use mygraphics_shaders::ShaderConstants;
use wgpu::{
ColorTargetState, ColorWrites, Device, FragmentState, FrontFace, MultisampleState,
PipelineLayoutDescriptor, PolygonMode, PrimitiveState, PrimitiveTopology, RenderPass,
RenderPipeline, RenderPipelineDescriptor, TextureFormat, VertexState, include_spirv,
RenderPipeline, RenderPipelineDescriptor, TextureFormat, VertexState, include_wgsl,
};

#[derive(Debug, Clone)]
Expand All @@ -17,7 +17,7 @@ impl MyRenderPipeline {
global_bind_group_layout: &GlobalBindGroupLayout,
out_format: TextureFormat,
) -> anyhow::Result<Self> {
let module = device.create_shader_module(include_spirv!(env!("SHADER_SPV_PATH")));
let module = device.create_shader_module(include_wgsl!(env!("SHADER_WGSL_PATH")));

let layout = device.create_pipeline_layout(&PipelineLayoutDescriptor {
label: Some("MyRenderPipeline layout"),
Expand Down
8 changes: 5 additions & 3 deletions generated/graphics/wgpu/spirv-builder/mygraphics/build.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,15 @@ pub fn main() -> anyhow::Result<()> {
.copied()
.collect::<PathBuf>();

let mut builder = SpirvBuilder::new(crate_path, "spirv-unknown-vulkan1.3");
let target = "spirv-unknown-naga-wgsl";
let mut builder = SpirvBuilder::new(crate_path, target);
builder.build_script.defaults = true;
builder.shader_panic_strategy = ShaderPanicStrategy::SilentExit;
builder.spirv_metadata = SpirvMetadata::Full;

let compile_result = builder.build()?;
let spv_path = compile_result.module.unwrap_single();
println!("cargo::rustc-env=SHADER_SPV_PATH={}", spv_path.display());
let artifact = compile_result.module.unwrap_single();

println!("cargo::rustc-env=SHADER_WGSL_PATH={}", artifact.display());
Ok(())
}
4 changes: 2 additions & 2 deletions generated/graphics/wgpu/spirv-builder/mygraphics/src/wgpu_renderer/render_pipeline.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ use mygraphics_shaders::ShaderConstants;
use wgpu::{
ColorTargetState, ColorWrites, Device, FragmentState, FrontFace, MultisampleState,
PipelineLayoutDescriptor, PolygonMode, PrimitiveState, PrimitiveTopology, RenderPass,
RenderPipeline, RenderPipelineDescriptor, TextureFormat, VertexState, include_spirv,
RenderPipeline, RenderPipelineDescriptor, TextureFormat, VertexState, include_wgsl,
};

#[derive(Debug, Clone)]
Expand All @@ -17,7 +17,7 @@ impl MyRenderPipeline {
global_bind_group_layout: &GlobalBindGroupLayout,
out_format: TextureFormat,
) -> anyhow::Result<Self> {
let module = device.create_shader_module(include_spirv!(env!("SHADER_SPV_PATH")));
let module = device.create_shader_module(include_wgsl!(env!("SHADER_WGSL_PATH")));

let layout = device.create_pipeline_layout(&PipelineLayoutDescriptor {
label: Some("MyRenderPipeline layout"),
Expand Down
24 changes: 20 additions & 4 deletions graphics/mygraphics/build.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,29 @@ pub fn main() -> anyhow::Result<()> {
let install = Install::from_shader_crate(crate_path.clone())
.within_build_script()
.run()?;
let mut builder = install.to_spirv_builder(crate_path, "spirv-unknown-vulkan1.3");
let mut builder = install.to_spirv_builder(&crate_path, "");
builder.build_script.defaults = true;
builder.shader_panic_strategy = ShaderPanicStrategy::SilentExit;
builder.spirv_metadata = SpirvMetadata::Full;

let compile_result = builder.build()?;
let spv_path = compile_result.module.unwrap_single();
println!("cargo::rustc-env=SHADER_SPV_PATH={}", spv_path.display());
// SPIR-V
{
builder.target = Some("spirv-unknown-vulkan1.3".to_owned());
let compile_result = builder.build()?;
println!(
"cargo::rustc-env=SHADER_SPV_PATH={}",
compile_result.module.unwrap_single().display()
);
}

// wgsl
{
builder.target = Some("spirv-unknown-naga-wgsl".to_owned());
let compile_result = builder.build()?;
println!(
"cargo::rustc-env=SHADER_WGSL_PATH={}",
compile_result.module.unwrap_single().display()
);
}
Ok(())
}
21 changes: 17 additions & 4 deletions graphics/mygraphics/build.rs.liquid
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,21 +14,34 @@ pub fn main() -> anyhow::Result<()> {
.copied()
.collect::<PathBuf>();

{% if api == "ash" -%}
let target = "spirv-unknown-vulkan1.3";
{% endif -%}
{% if api == "wgpu" -%}
let target = "spirv-unknown-naga-wgsl";
{% endif -%}

{% if integration == "spirv-builder" -%}
let mut builder = SpirvBuilder::new(crate_path, "spirv-unknown-vulkan1.3");
let mut builder = SpirvBuilder::new(crate_path, target);
{% endif -%}
{% if integration == "cargo-gpu" -%}
let install = Install::from_shader_crate(crate_path.clone())
.within_build_script()
.run()?;
let mut builder = install.to_spirv_builder(crate_path, "spirv-unknown-vulkan1.3");
let mut builder = install.to_spirv_builder(crate_path, target);
{% endif -%}
builder.build_script.defaults = true;
builder.shader_panic_strategy = ShaderPanicStrategy::SilentExit;
builder.spirv_metadata = SpirvMetadata::Full;

let compile_result = builder.build()?;
let spv_path = compile_result.module.unwrap_single();
println!("cargo::rustc-env=SHADER_SPV_PATH={}", spv_path.display());
let artifact = compile_result.module.unwrap_single();

{% if api == "ash" -%}
println!("cargo::rustc-env=SHADER_SPV_PATH={}", artifact.display());
{% endif -%}
{% if api == "wgpu" -%}
println!("cargo::rustc-env=SHADER_WGSL_PATH={}", artifact.display());
{% endif -%}
Ok(())
}
4 changes: 2 additions & 2 deletions graphics/mygraphics/src/wgpu_renderer/render_pipeline.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ use mygraphics_shaders::ShaderConstants;
use wgpu::{
ColorTargetState, ColorWrites, Device, FragmentState, FrontFace, MultisampleState,
PipelineLayoutDescriptor, PolygonMode, PrimitiveState, PrimitiveTopology, RenderPass,
RenderPipeline, RenderPipelineDescriptor, TextureFormat, VertexState, include_spirv,
RenderPipeline, RenderPipelineDescriptor, TextureFormat, VertexState, include_wgsl,
};

#[derive(Debug, Clone)]
Expand All @@ -17,7 +17,7 @@ impl MyRenderPipeline {
global_bind_group_layout: &GlobalBindGroupLayout,
out_format: TextureFormat,
) -> anyhow::Result<Self> {
let module = device.create_shader_module(include_spirv!(env!("SHADER_SPV_PATH")));
let module = device.create_shader_module(include_wgsl!(env!("SHADER_WGSL_PATH")));

let layout = device.create_pipeline_layout(&PipelineLayoutDescriptor {
label: Some("MyRenderPipeline layout"),
Expand Down
Loading