Repository navigation
Conversation
Every AES-GCM suite declared confidentiality_limit u64::MAX, which disables rustls' bound on how many records may be sealed with one key before the connection must be replaced. This copies the record-level limits used by rustls' own ring and aws-lc-rs providers: 1 << 24 for every AES-GCM suite, TLS 1.2 and TLS 1.3 alike. (The 1 << 23 values in those providers belong to their QUIC KeyBuilder blocks, a separate field for packet protection, not the record limit.) The ChaCha20Poly1305 suites keep u64::MAX, matching both providers, which cite draft-irtf-cfrg-aead-limits section 5.2.1 there. A regression test pins the limits for the four suites exported from the crate root.
The new limit_tests module was declared before kx; rustfmt orders module declarations alphabetically. cargo fmt --all -- --check is clean now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every AES-GCM suite declared confidentiality_limit u64::MAX, which disables rustls' bound on how many records may be sealed with one key before the connection must be replaced.
This copies the record-level limits used by rustls' own ring and aws-lc-rs providers: 1 << 24 for every AES-GCM suite, TLS 1.2 and TLS 1.3 alike. The ChaCha20Poly1305 suites keep u64::MAX, matching both providers, which cite
draft-irtf-cfrg-aead-limits section 5.2.1 there.
A regression test pins the limits for the four suites exported from the crate root.