Repository navigation
Fix: terminate running Redshift queries when SQLMesh is interrupted - #6144
Draft
gandeevanraghuramandd wants to merge 2 commits into
Draft
gandeevanraghuramandd wants to merge 2 commits into
gandeevanraghuramandd wants to merge 2 commits into
Conversation
On Ctrl-C, SnapshotEvaluator.concurrent_context() recycles the adapter before the context closes it. ThreadLocalConnectionPool.close_all() clears every thread's attributes, so close() no longer found the backend PIDs of queries still running on worker threads and left them running on Redshift. RedshiftEngineAdapter now terminates running queries in both recycle() and close(), before the pool is closed. If the calling thread was interrupted mid-query or mid-transaction, its connection is closed and the sessions are terminated from a new one. Also removes the SIGTERM-to-SIGINT mapping in the CLI, which is deferred to a follow-up so this change is scoped to Ctrl-C.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Test Plan
Checklist
make styleand fixed any issuesmake fast-test)git commit -s) per the DCO