Skip to content

fix(ci): wait for blocking - #6146

Merged
cmgoffena13 merged 1 commit into
SQLMesh:mainfrom
cmgoffena13:fix/ci-race-condition
Oct 15, 2026
Merged

cmgoffena13 merged 1 commit into
SQLMesh:mainfrom
cmgoffena13:fix/ci-race-condition

Conversation

@cmgoffena13

Copy link
Copy Markdown
Collaborator

Description

There's a race condition in test_restatement_plan_detects_prod_deployment_during_restatement -- it wants to raise ConflictingPlanError. Restatement happens and while its happening a plan happens and it should error. Sometimes the plan succeeds before the restatement even happens and no error is raised. This fixes that race condition.

Test Plan

Ran controlled test. It happens with multiple workers where resources are shared and timing issues are introduced.

Checklist

  • I have run make style and fixed any issues
  • I have added tests for my changes (if applicable)
  • All existing tests pass (make fast-test)
  • My commits are signed off (git commit -s) per the DCO

Signed-off-by: Cortland Goffena <30168413+cmgoffena13@users.noreply.github.com>
@cmgoffena13
cmgoffena13 merged commit f180e03 into SQLMesh:main Oct 15, 2026
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants