Repository navigation
fix(ci): wait for blocking - #6146
Merged
Merged
Conversation
Signed-off-by: Cortland Goffena <30168413+cmgoffena13@users.noreply.github.com>
StuffbyYuki
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
There's a race condition in
test_restatement_plan_detects_prod_deployment_during_restatement-- it wants to raiseConflictingPlanError. Restatement happens and while its happening a plan happens and it should error. Sometimes the plan succeeds before the restatement even happens and no error is raised. This fixes that race condition.Test Plan
Ran controlled test. It happens with multiple workers where resources are shared and timing issues are introduced.
Checklist
make styleand fixed any issuesmake fast-test)git commit -s) per the DCO