Repository navigation
Conversation
LouisParkin
reviewed
Oct 19, 2026
LouisParkin
left a comment
There was a problem hiding this comment.
Verdict: approve-with-nits. The workflow changes are sound: actions are SHA-pinned, permissions are minimal, Zizmor passes, $/ reusable refs run, and commits are signed. Before merging, scope down what enabling gomod turns on.
Medium: Specification
renovate.json:7::automergealso auto-merges every gomodrequireminor update. That applies to all 194go.modfiles in this fork. renovate-config#22 says to auto-merge only module patches andgolang.org/x/*minors, and to review other minors by hand. Fix: add a local rule that setsautomerge: falsefor gomodrequire/replaceminor updates outsidegolang.org/x/**, or fix the preset.- Dependabot security updates are still enabled on this repo (
automated-security-fixesreturnsenabled: true; Dependabot opened #546 on Oct 15). Neither this PR nor pulumi-infra#413 turns them off, but the description says "keep Dependabot security updates disabled". With gomod and OSV alerts enabled, both bots will raise PRs for the same modules. Fix: disable them through the owning IaC before merging, or correct the description.
Low: Specification
renovate.json:9,15: enabling gomod together with the Go preset (rangeStrategy: bumpfor thegolangdepType) will also bump modulegodirectives. Expect the ~51go 1.26.0lines to go into the auto-merged "Go build environment" group, because yourgolang-versionpatch rule matches them too. Expect the 141go 1.25.0lines to get a minor PR. The repo's own toolchain bump (14159e6) kept these atX.Y.0and changed only.go-version/go.work. If that convention should hold, add{"matchManagers":["gomod"],"matchDepTypes":["golang"],"enabled":false}.
Low: Standards
.github/workflows/auto-approve-bot-prs.yml:15: the gate hard-codesrefs/heads/stackstate-7.78.2. After the next upstream merge changes the default branch, the approver will stop without any error. Add this rename to the UPSTREAM_MERGE.md checklist.
Merge order: pulumi-infra#413 is still open, and both scheduled workflows depend on it. Lint and DEB CI were still running when this review was written.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the shared Go, Docker and automerge presets with scheduled Renovate and approval App workflows. Enable Go module discovery and track the compiler pins in
.go-versionandgo.worktogether.Use the standard SHA-pinned Zizmor action and replace the unsupported Actionlint pre-commit hook. Adopt self-repository references without new exceptions and document the approval guard update for default-branch renames.
Uses StackVista/renovate-config#29. Merge and apply StackVista/pulumi-infra#413 first for both Apps’ credentials and access; the updater App also needs Dependabot alerts read access. Pulumi disables agent’s Dependabot security updates while retaining alerts.
Go-only dry-run: 30 candidate PR groups, including 315 routine minor modules grouped into 3 PRs. A security-only module-minor rule would reduce this to 27 groups and preserve all 7 OSV security candidates. That rule is not included. Strict Go filtering may understate the queue; no update PRs were created.
Tracking: StackVista/renovate-config#22
Validation: Renovate schema, compiler extraction, authenticated Zizmor and its pre-commit hook passed. Both dry-run configurations completed successfully.