Repository navigation
docs: document public key allowed origins matching - #1337
stephenvapiai merged 2 commits into
Conversation
Allowed Origins matching rules were undocumented, and the page did not say assistant restrictions do not cover assistantOverrides.
Lightsage docs evalsWaiting for the staging docs URL before running evals. Lightsage will start the selected PR evals automatically when GitHub reports a successful docs deployment for this PR. This usually happens within 15 minutes. Commit: |
stephenvapiai
left a comment
There was a problem hiding this comment.
Two suggestions on lines outside the diff, so I can't attach them inline:
-
Line 20: line 27 now says only public keys support these restrictions, so change "then limit the key to the origins and assistants that need access" to "then limit a public key to the origins and assistants that need access."
-
Line 58: the new rules say any path is ignored, so these are origins, not URLs. Change "enter the URLs that may use the key in Allowed Origins" to "enter the origins that may use the key in Allowed Origins."
|
Applied all four suggestions, thanks. I reworded the "subdomain label" definition to "one dot-separated part of the host", since the |
Description
*wildcards, that partial wildcards never match, and that a key with no allowed origins works from any origin.assistantOverrideson those assistants.Evidence
TokenRestrictionsschema in the OpenAPI spec definesallowedOrigins.Testing Steps
fern check(pinned 5.151.1) passes locally