Repository navigation
OptimizeInstructions: Check mayNotReturn when refining ref.cast under TNH - #9256
Merged
tlively merged 1 commit intoOct 16, 2026
Conversation
tlively
reviewed
Oct 15, 2026
| // trap in the child either, unless control flow transfers and we | ||
| // might not reach the parent. | ||
| // trap in the child either. | ||
| // TODO: handle more cases. |
Member
There was a problem hiding this comment.
It might be even simpler to create an EffectAnalyzer with just the trap effect set, then check whether it is orderedBefore the effects of all the later children. Then we wouldn't have to list the particular effects we care about here or manually check trapsNeverHappen. That would also resolve this TODO. What do you think?
Contributor
Author
There was a problem hiding this comment.
Totally agreed. That would be much simpler 👍
tamaroning
force-pushed
the
optimize-instructions-tnh-cast-maynotreturn
branch
from
October 16, 2026 05:53
38cc29c to
1ff244a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #9246