Repository navigation
Conversation
find_replace.zig was a literal string replace standing in for `sed -e s/NN/32/g < elfxx-target.h`, which is what bfd's Makefile runs. On all thirteen substitutions this port makes, the two agree byte for byte. genscripts.zig already reaches for the host's shell, so sed is not a new kind of dependency here, only a more honest one.
Author
|
Opened by mistake against the wrong repo — this belongs on a fork. Closing; apologies for the noise. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
find_replace.zigwas 31 lines doing a literal string replace, standing in for what bfd's own Makefile runs:On all thirteen substitutions this port makes — the seven
elfxx-*.hpairs and the sixpeXXigen.cvariants — the two agree byte for byte.genscripts.zigalready spawns the host'ssh, and the script it runs uses the host'ssed,cat,mkdirandrmto write everyldscripts/*.x. Sosedhere is not a new kind of dependency, only a more visible one.