Skip to content

docs: update SECURITY.md - #34346

Open
dgp1130 wants to merge 1 commit into
angular:mainfrom
dgp1130:security-policy
Open

dgp1130 wants to merge 1 commit into
angular:mainfrom
dgp1130:security-policy

Conversation

@dgp1130

@dgp1130 dgp1130 commented Oct 14, 2026

Copy link
Copy Markdown
Collaborator

Adding some feedback based on AI security reports to help guide them towards what is and is not a legitimate vulnerability.

@dgp1130
dgp1130 requested a review from alan-agius4 October 14, 2026 22:08
@dgp1130 dgp1130 added area: docs Related to the documentation action: review The PR is still awaiting reviews from at least one requested reviewer target: minor This PR is targeted for the next minor release labels Oct 14, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates SECURITY.md to document the team's security policies and technical invariants regarding what constitutes a security vulnerability in Angular. The feedback suggests a minor correction to ensure consistent casing of 'DoS' throughout the document.

Comment thread SECURITY.md Outdated
Comment on lines +18 to +19
* Memory leaks are considered general bugs, not DOS vulnerabilities.
* While any memory leak is technically a DOS vulnerability in SSR, these are generally low enough impact to not be considered security issues.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For consistency with the rest of the document (which uses 'DoS' on lines 9, 11, 16, and 32), 'DOS' should be written as 'DoS'.

Suggested change
* Memory leaks are considered general bugs, not DOS vulnerabilities.
* While any memory leak is technically a DOS vulnerability in SSR, these are generally low enough impact to not be considered security issues.
* Memory leaks are considered general bugs, not DoS vulnerabilities.
* While any memory leak is technically a DoS vulnerability in SSR, these are generally low enough impact to not be considered security issues.

@dgp1130
dgp1130 force-pushed the security-policy branch 2 times, most recently from 40bb95c to c748581 Compare October 14, 2026 23:21
Adding some feedback based on AI security reports to help guide them towards what is and is not a legitimate vulnerability.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: review The PR is still awaiting reviews from at least one requested reviewer area: docs Related to the documentation target: minor This PR is targeted for the next minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant