Skip to content

core: Use ap_size_parameter_parse() for LimitXMLRequestBody - #847

Closed
arturobernalg wants to merge 1 commit into
apache:trunkfrom
arturobernalg:fix/limit-xml-size-parse
Closed

arturobernalg wants to merge 1 commit into
apache:trunkfrom
arturobernalg:fix/limit-xml-size-parse

Conversation

@arturobernalg

Copy link
Copy Markdown
Member

LimitXMLRequestBody got its own apr_strtoff() parsing in #825, before ap_size_parameter_parse() was added in #829. Use the common helper like LimitRequestBody does. No change in the accepted values.

Add LimitXMLRequestBody to the directives checked in test_012.


  • This PR does not report or address a security vulnerability
    (see SECURITY.md and
    https://www.apache.org/security/#reporting-a-vulnerability).
  • Code follows the httpd style guide.
  • New log messages (level debug or higher) use an empty APLOGNO() tag;
    numbers are assigned by a committer at merge time (see docs/log-message-tags/README).
  • If the change is user-visible, a changes-entries/*.txt file is included,
    following the template in README.CHANGES (not needed otherwise).
  • Test cases based on pyhttpd are included where appropriate, in the
    test/modules/xxx directory matching the modules/xxx module source,
    or test/modules/core for core server changes. On Unix, verify these
    pass locally with e.g. make check-pytest PYTEST_DIRS=test/modules/xxx.

LimitXMLRequestBody got its own apr_strtoff() parsing in apache#825, before
ap_size_parameter_parse() was added in apache#829. Use the common helper like
LimitRequestBody does. No change in the accepted values.

Add LimitXMLRequestBody to the directives checked in test_012.
@arturobernalg

Copy link
Copy Markdown
Member Author

Superseded by #848, which includes this change together with the fix of ap_size_parameter_parse() itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant