Repository navigation
Conversation
APACHE_ARG_MAX rather than ENV_COUNT_MAX. (send_req): Fail with APR_ENOSPC for an environment larger than APACHE_ARG_MAX. * test/modules/generators/test_001_cgid.py (test_generators_001_08_env_count_large, test_generators_001_09_env_count_overflow): New tests. * test/modules/generators/htdocs/cgi/envcount.py: New script. * changes-entries/cgid-env-limit.txt: New entry. PR: 70270 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Member
|
+1, looks good to me. |
uri_len and args_len by limit_req_line rather than APR_PATH_MAX. Submitted by: Emmanuel Dreyfus <manu netbsd.org> Reviewed by: jorton PR: 70270
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
values by new ENV_VAL_MAX rather than APR_PATH_MAX. * test/modules/generators/test_001_cgid.py (test_generators_001_15_long_query): New test. * test/modules/generators/htdocs/cgi/arglen.py: New script. PR: 70270 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Raise mod_cgid's limit on the number of environment variables passed to a script from the hardcoded 256 of
ENV_COUNT_MAXtoAPACHE_ARG_MAX(4096 on most platforms), fixing Bugzilla PR 70270. The limit is now also enforced on the sender side:send_req()fails withAPR_ENOSPCbefore writing anything to the daemon, so an oversized environment gets a clean 503 rather than a mid-protocol failure.Tested in
test/modules/generators: a 300-variable environment reaches the script intact (fails against trunk), and one over the limit is refused.🤖 Generated with Claude Code