Repository navigation
Infra: Standardize RustFS setup across Iceberg repos - #4017
Open
kevinjqliu wants to merge 2 commits into
Open
kevinjqliu wants to merge 2 commits into
kevinjqliu wants to merge 2 commits into
Conversation
Use /health/ready so bucket creation waits for storage/IAM readiness, enable stdout logging so `docker logs` shows output, and remove settings that are already defaults in rustfs/rustfs:1.0.0. Generated-by: GitHub Copilot Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
No unresolved issues were identified.
Review effort: Lite
Findings: None
What changed in this PR
Updates RustFS Docker Compose configurations to use readiness checks, stdout logging, and default settings.
Changes:
- Switches healthchecks to
/health/ready. - Enables RustFS stdout logging.
- Removes redundant default settings.
| File | Description |
|---|---|
dev/docker-compose.yml |
Updates standalone RustFS configuration. |
dev/docker-compose-integration.yml |
Updates integration RustFS configuration. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
kevinjqliu
marked this pull request as draft
September 25, 2026 04:17
Align with the RustFS setup used across Iceberg repos: bump the image to 1.0.3, set RUSTFS_CONSOLE_ENABLE=false, and stop publishing port 9001. Generated-by: GitHub Copilot Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
kevinjqliu
changed the title
kevinjqliu
commented
Oct 20, 2026
| - RUSTFS_ADDRESS=:9000 | ||
| - RUSTFS_CONSOLE_ENABLE=true | ||
| - RUSTFS_CONSOLE_ADDRESS=:9001 | ||
| - RUSTFS_OBS_LOG_STDOUT_ENABLED=true |
| - RUSTFS_CONSOLE_ENABLE=true | ||
| - RUSTFS_CONSOLE_ADDRESS=:9001 | ||
| - RUSTFS_OBS_LOG_STDOUT_ENABLED=true | ||
| - RUSTFS_CONSOLE_ENABLE=false |
Contributor
Author
There was a problem hiding this comment.
removes console port 9001, we dont need it
| - RUSTFS_SERVER_DOMAINS=object-store | ||
| healthcheck: | ||
| test: ["CMD-SHELL", "curl --fail http://127.0.0.1:9000/health"] | ||
| test: ["CMD-SHELL", "curl --fail http://127.0.0.1:9000/health/ready"] |
Contributor
Author
There was a problem hiding this comment.
The RustFS Status Check docs define the two endpoints differently:
-
/healthis a liveness check. It returns 200 "as long as the process is up". -
/health/readyis a readiness check. It returns 200 "only when storage, IAM, and peer health are ready", and 503 otherwise.
| - RUSTFS_VOLUMES=/data | ||
| - RUSTFS_ADDRESS=:9000 | ||
| - RUSTFS_CONSOLE_ENABLE=true | ||
| - RUSTFS_CONSOLE_ADDRESS=:9001 |
Contributor
Author
There was a problem hiding this comment.
these are all defaults, can remove
kevinjqliu
marked this pull request as ready for review
October 20, 2026 18:19
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Follow up to apache/iceberg#18246. Standardizes the RustFS setup across the Iceberg repos. Same change in:
The setup:
rustfs/rustfs:1.0.3, the latest stable./health/ready./healthis just liveness and can pass before storage and IAM are ready, so bucket creation can race it.RUSTFS_OBS_LOG_STDOUT_ENABLED=true. Otherwisedocker logsis empty.RUSTFS_CONSOLE_ENABLE=falseand no port 9001. Nothing uses the console.Are these changes tested?
Ran
docker compose configon both files and startedrustfs/rustfs:1.0.3with the new config:/health/readyreturns 200 and logs show up indocker logs.Are there any user-facing changes?
No.
AI Disclosure: Assisted by GitHub Copilot.