Skip to content

Use a string NodeImage name in the custom AMI example - #2190

Merged
micafer merged 2 commits into
apache:trunkfrom
Sanjays2402:docs/ec2-custom-ami-image-name
Oct 16, 2026
Merged

micafer merged 2 commits into
apache:trunkfrom
Sanjays2402:docs/ec2-custom-ami-image-name

Conversation

@Sanjays2402

Copy link
Copy Markdown
Contributor

Description

Fixes #2075.

The custom EC2 AMI example passes name=None to NodeImage, whose documented type is str. Use "Netflix Asgard", matching the image described in the example. The AMI ID and driver configuration are unchanged.

Validation: executed the complete example with a mock driver and verified the real NodeImage passed to create_node has the expected string name, AMI ID, and driver. Black and git diff --check passed. Prepared with Codex.

Status

done, ready for review

Checklist

  • Code linting
  • Documentation
  • Tests (example exercised with a mock driver)
  • ICLA (documentation-only change)

@micafer
micafer enabled auto-merge October 16, 2026 11:16
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.61%. Comparing base (cddf127) to head (58f0c25).

Additional details and impacted files
@@           Coverage Diff           @@
##            trunk    #2190   +/-   ##
=======================================
  Coverage   83.61%   83.61%           
=======================================
  Files         352      352           
  Lines       82045    82045           
  Branches     8799     8799           
=======================================
  Hits        68599    68599           
  Misses      10565    10565           
  Partials     2881     2881           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@micafer
micafer merged commit bd9cbb3 into apache:trunk Oct 16, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Is name=None correct for NodeImage constructor?

3 participants