Repository navigation
fix(ios): don't read the expo-updates launch asset before the controller starts - #508
Merged
hurali97 merged 1 commit intoOct 20, 2026
Conversation
…ler starts With expo-updates 57, EnabledAppController.launchAssetUrl() reads startupProcedure, an implicitly unwrapped optional that only start() sets. ExpoUpdatesStartup.prepareReactNative, ExpoHostRuntimeDelegate.bundleURL() and isBundleURLStable called it before start(), which crashed with EXC_BREAKPOINT. Check isStarted first.
hurali97
approved these changes
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #507
With expo-updates 57,
EnabledAppController.launchAssetUrl()traps if it runs beforestart(), becausestartupProcedureis an implicitly unwrapped optional.ExpoUpdatesStartup,ExpoHostRuntimeDelegate.bundleURL()andisBundleURLStablecould call it before the controller started.This PR checks
isStartedbefore each call. Beforestart()there is no launch asset, so Expo 58 behaves the same.Testing
yarn build,yarn lint,yarn typecheckpass.