Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Adds Vega OS, Amazon's React Native platform on new Fire TV devices. Today the slider shows "Unimplemented component: RNCSlider" there, because Vega has no native slider view
The PR adds one source file,
RNCSliderNativeComponent.kepler.tsx, with its tests. Metro picks it on Vega, like.web.tsxon the web. It draws the slider in React Native and works with a TV remote:minimumValue,maximumValue,step, limits,inverted,disabled, tint colors andthumbImagework.vertical,tapToSeek, track images,StepMarker.Android, iOS, Windows and web are unchanged. The README gets a short "Vega OS (Fire TV)" section.
Test Plan:
cd package && npm run lint && npm test: 31 tests pass, 15 of them new.npx tsc --noEmitpasses.<Slider minimumValue={0} maximumValue={100} step={1} value={50} />. Down moves the focus to the slider. Right, Right, Left give 51, 52, 51. Same result in three runs.The same test app on the stick, before and after:
Context: I build Fire TV apps on Vega OS and hit this while porting libraries to it.