Skip to content

V8 Backport: Show job GUID in service command progress hints - #3877

Merged
prkalle merged 2 commits into
cloudfoundry:v8from
sap-contributions:v8-job-guid-service-hints
Oct 20, 2026
Merged

prkalle merged 2 commits into
cloudfoundry:v8from
sap-contributions:v8-job-guid-service-hints

Conversation

@johha

@johha johha commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

Note: This is the v8 backport of #3876 (which targets main).

Description of the Change

v8 backport of #3876 — no behavior changes relative to that PR. When a service command returns while the async operation is still running (no --wait), it now also prints Job (<guid>) is being processed. so users and operators can trace the job via cf curl v3/jobs/<guid>. See #3876 for the full rationale and design.

Same change set as #3876, with v8 import paths. The 11 service lifecycle commands gain the hint; delete/delete-org/delete-space only pick up the updated WaitForResult signature and print nothing new.

Why Is This PR Valuable?

Keeps v8 in parity with main. See #3876.

Applicable Issues

See #3876.

How Urgent Is The Change?

Not urgent.

Other Relevant Parties

Same as #3876.


Note: this PR was developed with AI assistance, with manual review and testing by the author.

Async service operations run as CC jobs with no CLI-visible
handle. When a command returns before the job finishes
(no --wait provided), print the job GUID so users and operators can
trace it via 'cf curl v3/jobs/<guid>' which is the only key to that
job's status and warnings.
Comment thread command/v7/shared/result_waiter.go Outdated
WaitForResult is an exported function; changing its return type from
(bool, error) to (bool, string, error) would break external callers.

Introduce WaitForResultWithJobGUID as the GUID-returning variant and
keep WaitForResult as a thin wrapper that delegates to it, preserving
the original signature. Update the 11 service commands that need the
GUID to call WaitForResultWithJobGUID directly.
@johha
johha force-pushed the v8-job-guid-service-hints branch from 6e26c3a to 49b986d Compare October 20, 2026 12:30
@johha
johha requested a review from prkalle October 20, 2026 12:31

@prkalle prkalle left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@prkalle
prkalle merged commit f7e7206 into cloudfoundry:v8 Oct 20, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants