Repository navigation
Update test suite to ensure 100% code coverage - #53
Merged
Merged
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The coverage gate can succeed when the report or required metrics are missing.
1 open issue
What changed in this PR
Adds CI enforcement of 100% code coverage for the SSH connectors.
Changes:
- Generates Clover reports and checks coverage totals in CI.
- Adds an integration test for an incomplete SSH channel handshake.
- Excludes debug branches from coverage and documents coverage reporting.
| File | Description |
|---|---|
| tests/IntegrationSshProcessConnectorTest.php | Tests rejection when channel confirmation never arrives. |
| src/SshSocksConnector.php | Excludes debug blocks from coverage. |
| src/SshProcessConnector.php | Excludes debug blocks from coverage. |
| README.md | Adds coverage badge and reporting instructions. |
| .github/workflows/ci.yml | Generates and checks Clover coverage metrics. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changeset updates the CI setup to ensure 100% code coverage.
Builds on top of #52, #47 and clue/reactphp-eventsource#35