feat(memory): sharpen MCP tool descriptions for reliable invocation

[codeaholicguy]

Summary

Tightens the always-loaded MCP tool metadata in packages/memory/src/server.ts so agents retrieve memory before work and store after — without being told. Implements the top recommendations from the tool-metadata evaluation.

Two invocation failures being fixed:

1. Skipped pre-task recall — search was gated behind "any non-trivial task". Agents systematically self-assess tasks as trivial, so the check was skipped exactly when it mattered. No during-task trigger existed either, so agents retried errors blind instead of recalling prior fixes.
2. Missed/duplicate stores — store's "after completing meaningful work" cue was vague and missed the post-error/post-gotcha moment; dedupe was a soft preference rather than a procedure.

Before / after

Tool	Before	After
memory_searchKnowledge	"Call BEFORE starting any non-trivial task… Also call it when a task reveals a convention worth remembering later."	"Call BEFORE starting ANY task — trivial or not — and again IMMEDIATELY when you hit an error, test failure, or surprising behavior during work… Skip only for pure conversation with no action." (+ error-text example)
memory_storeKnowledge	"Persist verified, reusable knowledge… After completing meaningful work… Prefer updating an existing item over storing a near-duplicate."	"AFTER completing a task — and especially right after fixing an error, discovering a gotcha… Before storing, run memory_searchKnowledge; if a matching item exists, use memory_updateKnowledge instead of creating a near-duplicate. Do not store secrets, raw logs, task progress, or one-off details."
memory_updateKnowledge	"outdated or inaccurate"	"outdated, inaccurate, or incomplete" (covers additive updates)
search.query field	"Natural language task description…"	"Natural language task description — or paste the error text you just hit —…"
store.title field	"Short, explicit description of the rule"	"…written so a future agent knows when it applies"

server.descriptions.test.ts updated to pin the new phrasing while preserving its original intent (timing cue + example + dedupe cue); it now also asserts the error trigger and the store→update cross-reference.

Test plan

• packages/memory: vitest — 23 files / 171 tests pass
• Pre-commit hook: repo-wide fmt:check, lint, test (all 8 projects incl. Rust) pass
• git diff origin/main — only server.ts + the descriptions test changed

Generated with Devin