Repository navigation
Keep citation comments short: quote, clause, pointer (#760) - #763
Merged
Merged
Conversation
A citation comment now holds the quote, the clause the code implements and a decisions pointer. The five longest blocks in _pipeline/ carried issue history, measurements and examples that decisions/ already held, plus a few facts it did not: those move into dated #760 bullets in decisions/R1, P2, P3, S6 and W2. AGENTS.md states the convention beside the excerpt discipline. Code is AST-identical. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
R1: the ungated core read has a witness after all, the bracketed
clause 'Smith, MD (nee Jones) PhD' ('MD PhD' default, 'MD, PhD' when
the policy lists ' nee '); the comment now names that shape for the
non-core dropped arm. Group: chain_lead's lead is the last
title-particle even when there is one, the neighbour-join loop alone
skips a frozen subject, bare issue numbers trimmed. Script segment:
keep why the run predicate is not the token predicate's plural. W2:
right function name, the given-name cost restored. AGENTS.md: pointers
plural, and the AGENTS.md-quotes sentence back beside its referent.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #763 +/- ##
=======================================
Coverage 99.05% 99.05%
=======================================
Files 47 47
Lines 4642 4642
=======================================
Hits 4598 4598
Misses 44 44 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #760.
What changed
decisions/X (#N)pointers. A code-local reason a reader of that line needs may stay. Issue history, measurements and restated examples live in decisions/. The five blocks below are named as the case that earned the rule.nameparser/_pipeline/, 398 comment lines down to 110:_post_rules._mark_suffix_entries, R1: 100 → 28_group.py, P3 both-sides test: 59 → 18_group.py, S2/P2/P4 chain head: 86 → 24_group.py, S4 chain emitter: 68 → 20_script_segment._peel_honorific_tail, the peel's scope: 85 → 20. It had no citation; it now quotes rules/W3's decline sentence. The module already cited W3, so noimplemented:line moves.2026-10-19 #760 — MOVED FROM …bullet in decisions/R1, P2, P3, S6 or W2, with behavioral claims re-run on this tree.Found while moving
John Doe, MD nee Jones PhDnow reads the comma as a family comma, so the marker is never dropped. Review found a current witness for the same code path,Smith, MD (nee Jones) PhD: it renders 'MD PhD' by default and 'MD, PhD' underextra_suffix_delimiters={" nee "}. Both are recorded.PhDa title" was stale.田中さん, PhDputs PhD in suffix, as rules/W3's example line says.Verification
ast.dumpof each touched module is identical before and after.uv run pytest -qgives 21870 passed.uv run mypyanduv run ruff checkare clean.test_doc_citations.Does not touch mechanisms.md's structure or decisions/differential-ledger.md (#759 is restructuring those).
🤖 Generated with Claude Code