Repository navigation
reverse-string: fix approaches - #1049
Open
siebenschlaefer wants to merge 3 commits into
Open
siebenschlaefer wants to merge 3 commits into
siebenschlaefer wants to merge 3 commits into
Conversation
The code and description of the "Approach: Iterative" and "Approach: Linear Recursion" were incorrect. They did use the member function `std::string::append(char)` which does not exist. Replace it with `push_back(char)` and adjust the description.
The code in "Approach: Divide and conquer" was incorrect, it did use an invalid parameter name and closing parentheses were missing.
Remove unnecessary semicolons in comments. Fix plural-s errors. Replace "you" with an inclusive "we". Fix name of cppreference link.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #1044 did fix an incorrect use of
std::string::append()in the "Approaches" section of the reverse-string exercise.This PR fixes the other places where
std::string::append()has been used incorrectly.It also fixes another incorrect code snippet (in the "Linear Recursion" approach) and a few smaller grammatical issues.