Repository navigation
Conversation
`Sentry.cron.instrumentBullMQWorker(worker)` sends check-ins for every job the worker runs from a job scheduler, using the scheduler id as the monitor slug and its `pattern` or `every` as the monitor schedule. Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of a series adding automatic Crons monitoring for the most-used job schedulers in each SDK. Check-ins for a monitor that doesn't exist yet are dropped, so today each monitor has to be created by hand with its schedule copied from the code. Sending the job's schedule as the monitor config lets Sentry create the monitor and keep it in sync.
This adds
Sentry.cron.instrumentBullMQWorker, next to the existingcron,node-cronandnode-schedulehelpers. It listens to the worker'sactive,completedandfailedevents, so it also covers sandboxed (file) processors and never wraps or changes the processor. Every job that comes from a job scheduler gets in-progress and ok/error check-ins. The slug is the job scheduler id (job.repeatJobKey), not the job id.patternis sent as a crontab withtz(or the server's time zone, which is what cron-parser uses withouttz), andeveryas an interval when it's a whole number of minutes. Check-ins go out without a config for sub-minute schedules,?/W/Hsyntax, both day fields set in a way Sentry reads differently from cron-parser, fixed UTC offsets, and schedulers withlimitorendDate(they'd show as missed once they stop). Every accepted pattern shape was checked against cronsim for next-run dates with cron-parser 4 (BullMQ 5) and 5 (BullMQ 6). Legacy repeatable jobs (queue.addwithrepeat, removed in BullMQ 6) are keyed by a hash, so they aren't monitored.Docs: getsentry/sentry-docs#20053