Repository navigation
Conversation
Sends check-ins for every named node-cron task through the orchestrion createTask channel, with the task's schedule and time zone as monitor config when Sentry reads it the same way. Tasks without a name, and tasks wrapped by Sentry.cron.instrumentNodeCron, are skipped. Co-Authored-By: Claude <noreply@anthropic.com>
Prepares for other scheduler integrations; the helper also handles schedulers that run on either day field (cron-parser, cron). Co-Authored-By: Claude <noreply@anthropic.com>
The error event and the error check-in can arrive in either order. Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
size-limit report 📦
|
…-in modules `bun run` can't inject channels into libraries. nodeCronIntegration is opt-in, so it has no lazy channel-integration definition. Co-Authored-By: Claude <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of a series adding automatic Crons monitoring for the most-used job schedulers in each SDK. Check-ins for a monitor that doesn't exist yet are dropped, so today each monitor has to be created by hand with its schedule copied from the code. Sending the job's schedule as the monitor config lets Sentry create the monitor and keep it in sync.
Description
Adds
nodeCronIntegration, which sends check-ins for every namednode-crontask (3.x and 4.x) without wrapping the module inSentry.cron.instrumentNodeCron. It hookscreateTaskthrough the orchestrion channel injection, like the otherserver-utilsintegrations. Adding the integration is the opt-in; it is not a default integration.The slug is the task's
name. Tasks without anameget a random one fromnode-cron, so they are not monitored.excludeJobsmatches names exactly or by regex. Errors are captured and still reachnode-cronas before.The schedule and time zone (the server's time zone when
timezoneisn't set) are sent as the monitor config. A six-field expression is sent without its seconds field when that field is a single number. Schedules that can't be expressed in the Crons schedule format (for example, a task that runs every 10 seconds), restricted day-of-month and day-of-week together (node-cronrequires both, Sentry either),L/?/#, and fixed UTC offsets check in without a config.Tasks already wrapped by
instrumentNodeCronare skipped, so using both doesn't send duplicate check-ins.Testing
Unit tests for the schedule conversion (verified against
cronsim) and a node integration test with realnode-cron4 in ESM and CJS.