Repository navigation
Conversation
Rebuild the crontab from the parsed item, so Sentry reads the day fields the way graphile-worker does, and send it in UTC. Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
size-limit report 📦
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of a series adding automatic Crons monitoring for the most-used job schedulers in each SDK. Check-ins for a monitor that doesn't exist yet are dropped, so today each monitor has to be created by hand with its schedule copied from the code. Sending the job's schedule as the monitor config lets Sentry create the monitor and keep it in sync.
Description
graphileWorkerIntegration({ monitorCronJobs: true })now sends the crontab schedule with eachin_progresscheck-in, in UTC (graphile-worker always runs the crontab in UTC), so Sentry creates the monitor on the first run.The crontab is rebuilt from the values graphile-worker parsed rather than copied, because graphile-worker treats a day field that covers every day (like
1-31or*/1) as*, while Sentry treats any field starting with*(like*/2) as restricting. Rebuilt, a day field is*only when it matches every day, and lists otherwise, so both read it the same way:0 0 */2 * 1is sent as0 0 1,3,5,…,31 * 1. Minute, hour and month steps keep the*/nform. Items with a custommatchfunction check in without a config.Every crontab graphile-worker accepts can be expressed this way; I compared next run times from graphile-worker's matcher against Sentry's parser for a set of crontabs, including mixed day fields.
Stacked on #25475.