Repository navigation
Conversation
Sends check-ins for every named CronJob of the cron package (4.3+) through the orchestrion channel injection, with the cron expression and time zone as monitor config when Sentry reads it the same way. Bumps the cron dev dependency of the node integration tests to 4.x. Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
size-limit report 📦
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of a series adding automatic Crons monitoring for the most-used job schedulers in each SDK. Check-ins for a monitor that doesn't exist yet are dropped, so today each monitor has to be created by hand with its schedule copied from the code. Sending the job's schedule as the monitor config lets Sentry create the monitor and keep it in sync.
Description
Adds
cronJobIntegration, which sends check-ins for everyCronJobof thecronpackage that has aname, withoutSentry.cron.instrumentCron. Job names were added incron4.3.0, so older versions are not instrumented. Adding the integration is the opt-in. It's named afterCronJobbecauseSentry.cronis already the namespace of the wrapper functions.The slug is the job
name; jobs without one, and one-off jobs (aDateor LuxonDateTime), are not monitored. The cron expression andtimeZone(the server's time zone without one) are sent as the monitor config. Schedules that can't be expressed in the Crons schedule format (for example, a job that runs every 10 seconds), day-field combinations Sentry reads differently, andutcOffsetcheck in without a config. Jobs created byinstrumentCronare skipped.@nestjs/schedulecreates its jobs withCronJob.from()and passes the@Cron()name, so in NestJS apps usenestIntegration({ monitorCronJobs: true })(#25471) instead of this integration, or both send check-ins for the same job.The node integration tests move to
cron4.x, the version this needs; the existinginstrumentCronscenario only neededrunningrenamed toisActive.Testing
Node integration test with real
cron4.4 in ESM and CJS.Stacked on #25474.