Repository navigation
Conversation
`init()` copied `userOptions` into `options` and then called `applySdkMetadata()` on `userOptions`. When the user passed no `_metadata`, the copy did not get the new metadata. `@sentry/bun` then set its own `bun` metadata on the copy. All Elysia events reported as `sentry.javascript.bun`. Apply the metadata to `options`, the object passed to the Bun `init()`. The existing test mocked `applySdkMetadata()`, so it did not catch this. The new test uses the real function and checks the SDK name in the options passed to `init()`. Fixes #24045 Fixes JS-3580 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
isaacs
requested review from
chargome and
s1gr1d
and removed request for
a team
October 17, 2026 19:47
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
init()copieduserOptionsintooptionsand then calledapplySdkMetadata()onuserOptions. When the user passed no_metadata, the copy did not get the new metadata.@sentry/bunthen set its ownbunmetadata on the copy. All Elysia events reported assentry.javascript.bun.Apply the metadata to
options, the object passed to the Buninit(). The existing test mockedapplySdkMetadata(), so it did not catch this. The new test uses the real function and checks the SDK name in the options passed toinit().Fixes #24045
Fixes JS-3580