Repository navigation
Conversation
Contributor
Coverage Results 📊✅ 133768 passed | ⏭️ 7276 skipped | Total: 141044 | Pass Rate: 94.84% | Execution Time: 478m 33s 📊 Comparison with Base Branch
All tests are passing successfully. ✅ Patch coverage is 94.44% (17 of 18 changed executable lines covered; target 80%). Changed files with executable lines (2)
Coverage diff@@ Coverage Diff @@
## master #8049 +/-##
==========================================
- Coverage 90.26% 90.24% -0.02%
==========================================
Files 202 202 —
Tracked lines 26660 26678 +18
Branches 9926 9934 +8
==========================================
+ Hits 24062 24073 +11
- Misses 2598 2605 +7
- Partials 1510 1511 +1Generated by Coverage Action |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Streamed root segments wrote their name and source to the scope but never restored them on end, so later error events picked up a stale transaction. Save and restore both, and drop an inherited source when a no-op segment starts without one.
#7774 was closed on the basis that span streaming avoids this, but the same leak exists in streamed_span. This fix snapshots and restores state per root segment, so ending a child span doesn't clear the transaction (the concern raised on #7773).
Refs #7774