Repository navigation
Remove clear button listeners when autocomplete is destroyed - #164
Open
feritcemkahraman wants to merge 1 commit into
Open
feritcemkahraman wants to merge 1 commit into
feritcemkahraman wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
Cleanup matches the registered handler, and the regression test covers both reported failures.
0 open findings
What changed in this PR
Fixes autocomplete lifecycle cleanup so clear-button clicks do not affect disconnected inputs or emit duplicate changes after reconnection.
Changes:
- Remove the clear-button click listener in
destroy(). - Add regression coverage for disconnection and reconnection.
| File | Description |
|---|---|
| test/auto-complete-element.js | Verifies disconnected clicks do nothing and reconnected clicks emit one change. |
| src/autocomplete.ts | Removes the clear-button handler alongside other listeners. |
🧠 Review effort: Max
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After an autocomplete disconnects, its clear button still clears the old input and emits a change event. Reconnecting the element adds another handler, so subsequent clicks emit duplicate changes.
Remove the clear button's click listener alongside the other listeners in
destroy().The new Chromium regression fails before the fix and passes after it. All 51 Chromium tests, including the existing accessibility checks, pass. TypeScript, bundle/manifest generation, changed-file ESLint/format checks, and source ESLint with formatting disabled pass. Full lint reports unchanged Windows CRLF formatting differences; Firefox/WebKit were not run.