Repository navigation
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
jketema
force-pushed
the
jketema/bitint
branch
from
October 13, 2026 14:24
dbffbf5 to
9ee4d74
Compare
jketema
force-pushed
the
jketema/bitint
branch
6 times, most recently
from
October 14, 2026 09:15
2961468 to
3aebb27
Compare
jketema
force-pushed
the
jketema/bitint
branch
from
October 14, 2026 10:07
3aebb27 to
41fe11e
Compare
jketema
marked this pull request as ready for review
October 14, 2026 14:45
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Numeric consumers still confuse storage size with declared precision, and the downgrade emits an undefined type kind.
2 open findings
What changed in this PR
Adds C23 _BitInt(N) representation to CodeQL’s C/C++ schema and type library.
Changes:
- Adds bit-precise integer kinds and declared bit widths.
- Extends integral-type classification and width-preserving mappings.
- Adds schema migration files and a feature note.
| File | Description |
|---|---|
| cpp/ql/lib/upgrades/0853f43dc8c08deecb473c54a2b70da8597f1ab5/upgrade.properties | Declares upgrade compatibility. |
| cpp/ql/lib/upgrades/0853f43dc8c08deecb473c54a2b70da8597f1ab5/old.dbscheme | Records the pre-upgrade schema. |
| cpp/ql/lib/semmlecode.cpp.dbscheme | Adds integer kinds and bit-width metadata. |
| cpp/ql/lib/semmle/code/cpp/Type.qll | Exposes bit-precise types and mappings. |
| cpp/ql/lib/change-notes/2026-10-14-bitint.md | Announces the feature. |
| cpp/downgrades/6aec212e408fad907b19368a3376a4d9837783d2/upgrade.properties | Configures downgrade transformations. |
| cpp/downgrades/6aec212e408fad907b19368a3376a4d9837783d2/semmlecode.cpp.dbscheme | Records the downgrade target schema. |
| cpp/downgrades/6aec212e408fad907b19368a3376a4d9837783d2/old.dbscheme | Records the downgrade source schema. |
| cpp/downgrades/6aec212e408fad907b19368a3376a4d9837783d2/builtintypes.ql | Maps new kinds for older schemas. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| or | ||
| kind = 51 | ||
| or | ||
| 67 <= kind and kind <= 69 |
Contributor
Author
There was a problem hiding this comment.
This is correct, and might produce some FP/FN, but this does not seem worth fixing at this point given that we have not seen any real world use of _BitInt.
jketema
force-pushed
the
jketema/bitint
branch
from
October 14, 2026 15:24
e9cbd1c to
75d1cb9
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.