Skip to content

JS: Do not flag computed __proto__ properties #22829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eugeniodepalo wants to merge 1 commit into
base: main
Choose a base branch
from
Open

JS: Do not flag computed __proto__ properties #22829

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion javascript/ql/src/LanguageFeatures/InvalidPrototype.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,11 @@ private import semmle.javascript.dataflow.InferredTypes
*/
predicate isProto(DataFlow::AnalyzedNode e) {
// `o.__proto__ = e`, `{ __proto__: e }`, ...
e = any(DataFlow::PropWrite pwn | pwn.getPropertyName() = "__proto__").getRhs()
e =
any(DataFlow::PropWrite pwn |
pwn.getPropertyName() = "__proto__" and
not pwn.getWriteNode().(Property).isComputed()
).getRhs()
or
// Object.create(e)
e = DataFlow::globalVarRef("Object").getAMemberCall("create").getArgument(0)
Expand Down
4 changes: 4 additions & 0 deletions javascript/ql/src/change-notes/2026-10-15-invalid-prototype-computed-property.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
---
category: minorAnalysis
---
* The `js/invalid-prototype-value` query no longer reports computed `__proto__` properties in object literals.
2 changes: 2 additions & 0 deletions javascript/ql/test/query-tests/LanguageFeatures/InvalidPrototype/InvalidPrototype.expected
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,5 @@
| tst.js:8:27:8:28 | 42 | Values of type number cannot be used as prototypes. |
| tst.js:9:15:9:18 | true | Values of type boolean cannot be used as prototypes. |
| tst.js:10:1:10:10 | "function" | Values of type string cannot be used as prototypes. |
| tst.js:15:25:15:26 | 42 | Values of type number cannot be used as prototypes. |
| tst.js:17:19:17:20 | 42 | Values of type number cannot be used as prototypes. |
6 changes: 6 additions & 0 deletions javascript/ql/test/query-tests/LanguageFeatures/InvalidPrototype/tst.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,3 +9,9 @@ Object.setPrototypeOf(o2, 42); // $ Alert
Object.create(true); // $ Alert
"function".isPrototypeOf(o2); // $ Alert

var o3 = { ["__proto__"]: 42 };
var o4 = { ["__proto__"]: null };

var o5 = { "__proto__": 42 }; // $ Alert
var o6 = {};
o6["__proto__"] = 42; // $ Alert
Loading