Repository navigation
Java/Ruby: Replace recursive algorithm string builders - #22837
Merged
jketema merged 1 commit intoOct 17, 2026
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The refactor preserves existing regex construction, with only optional cleanup remaining.
0 open findings
What changed in this PR
Replaces recursive algorithm-string builders in Java and Ruby CodeQL security analysis with ordered concatenation aggregates.
Changes:
- Preserves descending algorithm order and
|separators. - Updates regex helpers to use parameterless builders.
| File | Description |
|---|---|
| ruby/ql/lib/codeql/ruby/security/OpenSSL.qll | Replaces secure and insecure algorithm builders with aggregates. |
| java/ql/src/experimental/quantum/Examples/BrokenCrypto.ql | Replaces the insecure algorithm builder with an aggregate. |
| java/ql/lib/semmle/code/java/security/Encryption.qll | Replaces the secure algorithm builder with an aggregate. |
🧠 Review effort: Max
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
owen-mc
approved these changes
Oct 17, 2026
owen-mc
left a comment
owen-mc
left a comment
Contributor
There was a problem hiding this comment.
Seems like a simple refactor.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.