Skip to content

docs: distinguish extension events from hooks - #5026

Merged
mnriem merged 2 commits into
github:mainfrom
mnriem:mnriem-fix-lifecycle-event-docs
Oct 19, 2026
Merged

mnriem merged 2 commits into
github:mainfrom
mnriem:mnriem-fix-lifecycle-event-docs

Conversation

@mnriem

@mnriem mnriem commented Oct 19, 2026

Copy link
Copy Markdown
Collaborator

Description

Separates extension runtime events from Spec Kit command hooks in the README capability table. Adds a focused runtime-events reference that documents the canonical lifecycle events and clarifies how they differ from command hooks.

Testing

Documentation-only change. git diff --check passed.

  • Tested locally with uv run specify --help
  • Ran existing tests with uv sync && uv run pytest
  • Tested with a sample project (if applicable)

AI Disclosure

  • I did not use AI assistance for this contribution
  • I did use AI assistance (fill in the disclosure below)

AI disclosure: GitHub Copilot using GPT-5.6 Sol in autonomous mode identified the terminology mismatch, updated the README table, and authored the related extension-reference documentation. The contribution is documentation-only.

Assisted-by: GitHub Copilot (model: GPT-5.6 Sol, autonomous)

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: bbf74d70-31fd-4ffd-96aa-dd4459cddbfb
Copilot AI max review requested due to automatic review settings October 19, 2026 17:22
@mnriem mnriem added the triage-can-wait Verdict: valid and in-scope but deprioritized; held behind the evidence gate label Oct 19, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The runtime-events reference needs accuracy corrections before publication.

3 open issues
What changed in this PR

Clarifies the distinction between extension runtime events and Spec Kit command hooks.

Changes:

  • Separates events and hooks in the README capability table.
  • Adds a runtime-events reference with canonical event names and an example.

AI review for the requester: GitHub Copilot (model unavailable; autonomous); documentation review and suggested fixes.

File Description
README.md Separates event and hook capabilities and links.
docs/​reference/​extensions.md Documents runtime events and contrasts them with hooks.

Review effort: Max

Comment thread docs/reference/extensions.md Outdated
Comment thread docs/reference/extensions.md Outdated
Comment thread docs/reference/extensions.md Outdated
Assisted-by: GitHub Copilot (model: GPT-5.6 Sol, autonomous)

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: bbf74d70-31fd-4ffd-96aa-dd4459cddbfb
Copilot AI max review requested due to automatic review settings October 19, 2026 17:47
@mnriem

mnriem commented Oct 19, 2026

Copy link
Copy Markdown
Collaborator Author

Addressed the runtime-events review in commit 6a4a8538:

  • Kept the extension manifest example integration-agnostic by removing the Claude-specific matcher.
  • Clarified that every installed event-capable integration translates canonical event declarations into its agent-native configuration.
  • Documented that runtime events execute the referenced command template's scripts entry directly and require a runnable script.

git diff --check passed. No executable tests were run because the changes are documentation-only.

AI disclosure: Posted for mnriem by GitHub Copilot using GPT-5.6 Sol in autonomous mode; documentation edits and review-round summary.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The documentation matches the extension design, addresses prior feedback, and has no unresolved issues.

No open issues 🎉

3 resolved since last review

Review effort: Max

@mnriem
mnriem merged commit fe44f49 into github:main Oct 19, 2026
16 checks passed
@mnriem
mnriem deleted the mnriem-fix-lifecycle-event-docs branch October 19, 2026 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

triage-can-wait Verdict: valid and in-scope but deprioritized; held behind the evidence gate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants