Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #30617
What is the current behavior?
Currently, replacing a page inside a tab stack breaks going back in two different ways. Calling
useIonRouter().replace()shows a back button that does nothing, becausereplace()sends therootdirection, which clears the location history but leavespushedByRouteset. Callingnavigate(path, 'forward', 'replace')after switching tabs does the opposite, so the URL goes back but the replaced page stays on screen. That one happens because the back button callsrouter.go(-3)and the router assumes the page we left is only one entry ahead.What is the new behavior?
Now
replace()uses thenonedirection, so it keeps the pages beneath the one it replaced and still doesn't animate, the same as a plainrouter.replace(). The router also uses the real history delta to find the page we left, and an explicitnavigate(url, 'root', 'replace')no longer shows a back button since there's nothing to go back to.Does this introduce a breaking change?
Other information
This does change
replace()for apps that relied on it clearing the history. That only started in 9.0, when #31142 made the router respect the caller's direction, and those apps can switch tonavigate(url, 'root', 'replace'). I updated theuseIonRouterdocs in ionic-docs to match here: ionic-team/ionic-docs#4794