Repository navigation
Conversation
Concurrent requests sharing an Electrum connection can remain blocked when the active reader sees a clean EOF. This can keep blocking Tokio workers alive through node shutdown. Pin the upstream fix until it is released and cover the failure at the LDK Node boundary so dependency updates cannot reintroduce the hang. Fixes lightningdevkit#1007 Co-Authored-By: HAL 9000
|
👋 Hi! This PR is now in draft status. |
Collaborator
Author
|
Closing as superseded by #1182 |
tnull
added a commit
to tnull/ldk-node
that referenced
this pull request
Oct 20, 2026
Concurrent requests sharing an Electrum connection can remain blocked when the active reader sees a clean EOF. This can keep blocking Tokio workers alive through node shutdown. Require the released fix in electrum-client 0.25.1 and cover the failure at the LDK Node boundary so dependency updates cannot reintroduce the hang. BDK Electrum now supports this client version. Fixes lightningdevkit#1007 Refs lightningdevkit#1055 (cherry picked from commit aff6ce0) Co-Authored-By: HAL 9000
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Concurrent requests sharing an Electrum connection can remain blocked when the active reader sees a clean EOF. This can keep blocking Tokio workers alive through node shutdown.
Add a regression test based on the upstream fix.
Fixes #1007
Co-Authored-By: HAL 9000