Repository navigation
Pin compatible nightly rustfmt - #1120
Merged
Merged
Conversation
Nightly rustfmt from September 23 rewrites code that stable rustfmt changes back, causing the weekly formatting PR to fail CI. Pin the last compatible nightly to keep weekly formatting usable. Co-Authored-By: HAL 9000
|
👋 I see @TheBlueMatt was un-assigned. |
Collaborator
Author
|
Reassigned to @joostjager to get this out of the way soon, it's trivial. |
joostjager
approved these changes
Oct 12, 2026
joostjager
left a comment
joostjager
left a comment
Contributor
There was a problem hiding this comment.
Is it useful to track switching back to latest nightly? (I think when stable rust changes?)
Collaborator
Author
Hmm, I don't know, yes eventually we should bump it, but not sure it's worth tracking anywhere separately. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nightly rustfmt from September 23 rewrites code that stable rustfmt changes back, causing the weekly formatting PR to fail CI. Pin the last compatible nightly to keep weekly formatting usable.
Co-Authored-By: HAL 9000