Repository navigation
Fix CI for the 0.7 release branch - #1155
Merged
tnull merged 11 commits intoOct 12, 2026
Merged
Conversation
New idna_adapter releases pull in ICU dependencies that need a newer compiler than the Rust 1.85 MSRV used by the release branch. Keep the MSRV jobs on idna_adapter 1.2.0 so the declared minimum Rust version remains usable without restricting stable builds. Backport of 38b6122 Co-Authored-By: HAL 9000
Recent encoding_rs releases require Rust 1.88, exceeding the release branch's declared Rust 1.85 minimum. Keep the MSRV jobs on encoding_rs 0.8.35, matching the compatibility pin already used on main. Backport of 87946b1 Co-Authored-By: HAL 9000
The Rust 1.85 CI jobs resolve proptest 1.12.0, which requires Rust 1.88 and prevents the MSRV tests from building. Keep those jobs on proptest 1.11.0 so they can continue checking the declared minimum compiler version. Backport of c7ebb9c Co-Authored-By: HAL 9000
Rust 1.99 warns when LDK logging macros expand with a trailing semicolon in expression position. These warnings fail stable CI, which denies warnings. Terminate the affected calls explicitly, adapting the upstream fix to the 0.7 source layout without changing logging behavior. Backport of b6e37fa Co-Authored-By: HAL 9000
The release workflows still use actions with obsolete Node.js runtimes. Current workflow lint rejects several of those versions. Bring forward the action upgrades from main, retaining the release branch's Python setup rather than changing its build tooling. Backport of b3fe392 Co-Authored-By: HAL 9000
The 0.7 bindings expose a FeeRate constructor that newer Bitcoin dependencies deprecate. Denying that warning fails CI, but renaming the constructor would break existing binding users. Allow deprecation warnings only in UniFFI build and check steps for 0.7.x. Other warnings and later release lines retain the existing warning policy, and the public binding API stays unchanged. Co-Authored-By: HAL 9000
VSS moved its Rust implementation to the repository root. The release workflow still uses the old location and cannot start the server checked out from the current upstream branch. Use the current server location, matching the upstream CI fix. Backport of bfad8e6 Co-Authored-By: HAL 9000
The VSS server now requires authentication by default, while 0.7 integration tests use fixed headers without authentication. Those tests fail against a server started with the default features. Enable the server's explicit no-auth mode for 0.7.x checkouts only. Later release lines keep their existing authentication behavior. Co-Authored-By: HAL 9000
The Rust workflow uses Bash syntax for toolchain setup and GitHub environment files. Windows runners otherwise default to PowerShell, which does not interpret those commands consistently. Select Bash for the build matrix so all platforms execute the same setup commands with the expected shell semantics. Co-Authored-By: HAL 9000
Restoring either test binary cache creates the bin directory. If the other cache misses, the download step fails when it tries to create that existing directory. Allow an existing bin directory in Rust and benchmark CI so partial cache restores can still download the missing binaries. Co-Authored-By: HAL 9000
|
👋 Thanks for assigning @joostjager as a reviewer! |
joostjager
approved these changes
Oct 12, 2026
joostjager
left a comment
joostjager
left a comment
Contributor
There was a problem hiding this comment.
Indeed no functional code changes, just CI. Did note that not every commit links to a main branch one.
Collaborator
Author
Ah, seems LND CI still needs fixing, will update shortly. |
Newer lnd_grpc_rust releases removed the SendPaymentSync request and client method. The 0.7 LND integration test still uses that API and fails to compile against the current dependency release. Adapt the payment RPC portion of main's LND test harness to use SendPaymentV2, preserving successful-payment and nonempty-preimage checks. Fail if the payment fails or its stream ends prematurely. Backport of 269e396 Co-Authored-By: HAL 9000
joostjager
approved these changes
Oct 12, 2026
| &response.payment_error | ||
| } | ||
| ); | ||
| while let Some(payment) = stream.message().await.expect("Failed to read LND payment update") |
Contributor
There was a problem hiding this comment.
I think there is just one update with no_inflight_updates? Not that it matters much.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We fix our CI as we prepare for an upcoming release.