Repository navigation
Conversation
mawilk90
requested review from
jcamelon,
lgarber-akamai and
psnoch-akamai
and
a balanced review from Copilot
and removed request for
a team and
jcamelon
October 19, 2026 12:21
mawilk90
added
testing
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The cancellation test still rejects completed snapshots, leaving a timing-dependent failure.
1 open issue
What changed in this PR
Fixes backup integration-test configuration and snapshot handling.
Changes:
- Wires snapshot tests and fixtures to the cloud firewall fixture.
- Adds Linode cleanup after the snapshot test.
- Lists existing backups before testing cancellation.
| File | Description |
|---|---|
| tests/integration/linodes/test_backups.py | Updates fixture usage, cleanup, and cancellation checks. |
| tests/integration/linodes/fixtures.py | Passes the cloud firewall to snapshot Linode creation. |
Review effort: Balanced
lgarber-akamai
approved these changes
Oct 19, 2026
ezilber-akamai
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Some of the backup tests fail due to incorrect configuration.
✔️ How to Test
export RUN_LONG_TESTS=Truemake test-int TEST_SUITE=linodes TEST_ARGS="-k backup -v"